eksopl / fuuka

Fuuka Imageboard Archiver
http://code.google.com/p/fuuka/
Other
58 stars 7 forks source link

Refine backlink preview function #4

Open eksopl opened 12 years ago

eksopl commented 12 years ago

Backlink preview on hover has been implemented with the help of a patch from @desuwa, but I'd like to still:


(Imported from issue 72 @ Google Code)

eksopl commented 12 years ago

Attaching original quote patch posted on Google Code, just for archival purposes.

https://gist.github.com/1861380/

desuwa commented 12 years ago

Here's a quick port of the userscript I was using for fuuka: https://github.com/desuwa/fuuka/tree/quoting Behaves pretty much exactly like foolzfuuka.

See if it can help in some way.

eksopl commented 12 years ago

Checking, thanks!

Still getting accustomed to Git.

eksopl commented 12 years ago

Looks good, merged.

I looked at how it breaks on IE8 because of getElementsByClassName(), but I don't think that anyone using IE8 cares for having anything nice, so.

desuwa commented 12 years ago

Any ideas on how you want to make it optional?

Would it be okay to add one or two links to the top menu (Quote Preview On/Off) and save those settings to localStorage?

eksopl commented 12 years ago

Umh, not entirely sure where to place such an option. But sure, go ahead!

desuwa commented 12 years ago

Soon( ≖‿≖)

edit: oh my god, it's already live: http://archive.installgentoo.net/cgi-board.pl/g/

eksopl commented 12 years ago

The only thing I miss about easymodo is being able to use it as a bleeding edge testbed, but @GXTX is a true follower of the cause.

Also, since I'm already requesting things, how about an underline or (OP) on backlinks that link to the OP? Plus, it seems the OP isn't entitled to "Quoted by" links either.

GXTX commented 12 years ago

Bleeding edge master race reporting in.

Although I wouldn't update if eksopl said he didn't know if it was stable.

desuwa commented 12 years ago

underline or (OP) on backlinks

Yep, I completely forgot about that.

the OP isn't entitled to "Quoted by" links

I'll add it if you want. My reasoning behind this is that when people reply to a thread, they are normally quoting OP by default, unless they explicitly quote another post.

eksopl commented 12 years ago

Yeah, the second one isn't that serious once you have the first one, since, like you said, all posts are implicitly quoting the OP. But it's pretty useful to mark backlinks to the OP in some way, so you don't bother hovering them.

desuwa commented 12 years ago

https://github.com/desuwa/fuuka/commit/bded1c3a3f0e1cc9a9f20b63a6e804c32dd109ba

Also fixes backlinking from ghost posts, forgot to add it to the commit message.

eksopl commented 12 years ago

Looks good, merged! Once more, thank you for your patronage.

I don't really use scripts for fuuka, but I don't think turning subreplys into subreply replys will break any of them, so.

desuwa commented 12 years ago

Looks like I forgot a line: linklist[replies[i].id] = true; after here

It caused this basically, where the very first "quoted by" link could appear twice in some cases.

(´・ω・`)