update json to 1.8.3 - Githubissues

eksoverzero / newrelic_sidekiq_agent

Sidekiq monitoring through New Relic

MIT License

15 stars 19 forks source link

Closed Overbryd closed 7 years ago

Overbryd commented 8 years ago

Updated json to 1.8.3 because json 1.8.1 failed to compile.

Please also push and create a new tag. (1.1.1 is missing for example).

darthjee commented 8 years ago

Didn't see this, I am closing my PR

Just so that everyone know, with 1.8.1, it does not work on ruby 2.3.0, but with 1.8.3, it will work on 2.0.0 and on

Overbryd commented 8 years ago

Added a new fix and tagged my fork to 1.1.3 now.

Your version of the agent leaks file descriptors, because each poll cycle a new redis client is initialised.

emurphy commented 8 years ago