search

ekuefler / gwt-supereventbus

High-octane event bus for GWT
https://ekuefler.github.io/gwt-supereventbus
Apache License 2.0
39 stars 2 forks source link

EventRegistration should include methods from superclasses #9

Closed flavor8 closed 10 years ago

flavor8 commented 10 years ago

Right now EventRegistration#getMethods only observes subscribed methods in the same class. It would be nice if it walked up the superclass hierarchy and added any annotated methods from ancestor classes as well.

Use case: I have several views that all share the same layout. I want to encapsulate the behavior of the layout (which has some events it should react to) in a superclass, and have the view classes entirely focused.

ekuefler commented 10 years ago

I fixed it to scan all inheritable methods back in commit 0024e3d1a3ac277af000ef5810110028be1f9114 a couple months ago, but haven't pushed out a new version since then. Can you check whether the latest snapshot works like you want it to? If show I can push out a new version to Maven with that commit.

flavor8 commented 10 years ago

This works great. Please push when you get a chance.

ekuefler commented 10 years ago

I've just pushed v0.1.1 with this change. It should be synced to Maven central in a few hours.