search

ekumenlabs / roscpp_android

Cross compilation scripts for building ROS nodes using the Android NDK.
39 stars 30 forks source link

Use dockerhub image instead of building it #33

Closed garyservin closed 8 years ago

garyservin commented 8 years ago

@ernestmc or @adamantivm

adamantivm commented 8 years ago

looks good other than minor comment nit. It would be nice to have someone else test it before merging.

garyservin commented 8 years ago

I've tested it on my existing workspace, I'll try it with a fresh workspace.

adamantivm commented 8 years ago

I think it would be much better if you get someone else to try it, for better variability control

ernestmc commented 8 years ago

I'll test it.

ernestmc commented 8 years ago

+1 Looks good to merge.