ekumenlabs / safe-control-gym

MIT License
0 stars 1 forks source link

Retuning, reduces avg time by almost a second #5

Closed glpuga closed 2 years ago

glpuga commented 2 years ago

Tried over 50 episodes. There was a single collision, but since I can't know the start seed I don't know the reason for the collision.

Looks promissory, though, would reduce the lap time to between 9.7 and 9.9 seconds.

glpuga commented 2 years ago

Screenshot from 2022-10-15 20-01-38

glpuga commented 2 years ago

Put this on hold until further notice, found a problem...

glpuga commented 2 years ago

Looking good again.

I needed to help it with your "minimal corrections" commit to get it through the finish line.

In 100 episodes there were two collisions on the second gate. I've got no record of the start seeds, but in that gate I suspect that the minimum correction may have hit the frame when turning left.

If we have time, check if you can verify the performance of this change.

hidmic commented 2 years ago

@glpuga Indeed, we get a nice reduction in average flight time:

flight_time_distribution

But we have lots of collisions:

glpuga commented 2 years ago

:cry: well, it was a good try, closing this.

hidmic commented 2 years ago

@glpuga I think this is promising, even if we decide not to merge for the competition. It just needs some tuning.

glpuga commented 2 years ago

I agree, but tuning is time consuming, so I think at this stage it's better begin closing the submission and just test that what we submit is not missing anything important.

10.8 sec is good, especially if it requires no training, and it's more robust. We'll do fine.