ekumenlabs / terminus

Library to create cities and terrains
Apache License 2.0
56 stars 29 forks source link

Issue/#216 new mcity implementation #231

Closed agalbachicar closed 7 years ago

agalbachicar commented 7 years ago

With the gained experience gained in https://github.com/ekumenlabs/terminus/pull/218 we moved to a new approach. I have created a city from a picture of MCity in a CAD program and that was translated to a handwritten Monolane. It respects the vertical scale to it approximates to the length.

Just for future reference:

Some pictures of the road are shown below:

a b d e

closes #216

basicNew commented 7 years ago

Thanks a lot for all the work on this @agalbachicar ! Couple of minor fixes (btw, for the overlapping cases, it should be easier to just make the segment shorter instead of making the arc fit):

screenshot from 2017-04-10 14 40 31 screenshot from 2017-04-10 14 41 39 screenshot from 2017-04-10 14 43 16

And a couple of extensions so we don't leave dead-end streets:

screenshot from 2017-04-10 14 46 39 screenshot from 2017-04-10 14 47 57

Once we have that I think it should be good for a first pass with TRI.

agalbachicar commented 7 years ago

All comments were addressed. Here are some pictures of the new connections:

upper

lower

@basicNew ready for a new review.

basicNew commented 7 years ago

Ok, I think it is time to merge. Go and open a champagne bottle @agalbachicar :fireworks: :boom: :champagne:

agalbachicar commented 7 years ago

This is a great day :)