search

ekumenlabs / terminus

Library to create cities and terrains
Apache License 2.0
56 stars 29 forks source link

Reduce smoothing curves on SVG #66

Closed agalbachicar closed 7 years ago

agalbachicar commented 7 years ago

Fuctional description: reduce the smoothing on SVG. Threre are a lot of small segments generated and it is difficult to work with them when debugging.

For future work we should control the curve resolution points.

basicNew commented 7 years ago

@agalbachicar this one can be closed, right?

agalbachicar commented 7 years ago

@basicNew yes.

agalbachicar commented 7 years ago

From this PR we have some lists of lanes and its waypoints so we can make smooth curves on those that have more than two points. This will make easier to control and define resolution and algorithm of the curves. I think we could user Bezier or Splines.

@basicNew you have some ideas, don't you?

basicNew commented 7 years ago

Just a thought: if making splines/bezier curves is too much of a trouble, maybe we could use the points the PPM representation generates. Between every two waypoints the PPM generates a set of intermediate points (lots of them) for both the center of the street as well as the borders. Maybe we could sample the center points (e.g. 1 out of 10) and generate an SVG polyline with that, so it would look smoother and we would be reusing the existing points.

agalbachicar commented 7 years ago

Those points belong to a Bezier curve as far as I understand, so it will be a nice trade-off to sample those points.

basicNew commented 7 years ago

@agalbachicar what is the status of this one?

agalbachicar commented 7 years ago

@basicNew I think we can close this one if we are not going to work on this. I'm totally focused on the Gazebo plugin.

basicNew commented 7 years ago

@agalbachicar I was just confused about the labels it had in the past. But agreed that there is no point in keeping an issue that we won't fix.