ekutner / home-connect-hass

Alternative (and improved) Home Connect integration for Home Assistant
MIT License
549 stars 54 forks source link

Added Traditional Chinese translation #179

Closed tsunglung closed 1 year ago

tsunglung commented 1 year ago

Added Traditional Chinese translation

ekutner commented 1 year ago

Hi @tsunglung

  1. Any reason for providing the translation as unicode tags instead of just Chinese text? It would be better if the translation was readable to humans.
  2. You need to to provide the select translation file as well (you can just copy the sensor file).
tsunglung commented 1 year ago
  1. From Python document Python’s string type uses the Unicode Standard for representing characters, which lets Python programs work with all these different possible characters. Also using unicode saving is better for multiplatform (Windows, MacOS, Ubuntu). And HA core also uses unicode in translation files.
  2. As attachment. sensor.txt
ekutner commented 1 year ago

The comment wasn't about unicode per-se but about using the encoded unicode tags instead of just the text, which by the way works just fine and is much easier to understand. However, I see that you are right and most translation files in the core HA take this approach, so I'm going to commit it like that although I think it's a bad idea.

Thanks for contributing