search

ekutner / home-connect-hass

Alternative (and improved) Home Connect integration for Home Assistant
MIT License
494 stars 53 forks source link

simplify check if enum is boolean #283

Closed yuvalabou closed 8 months ago

yuvalabou commented 8 months ago

Has been tested to work localy

ekutner commented 8 months ago

I don't mean to be a jerk but there is no reason to correct working code for stylistic reasons. PRs should be submitted for bugs of improvements. Your changes are both unnecessary and logically wrong. The first will cause an exception to be raised if values is None and the second is both less efficient than the previous code and also logically wrong because it doesn't do the same thing. It doesn't check if the string ends with "on" or "off". So I'm closing this PR.