search

ekutner / home-connect-hass

Alternative (and improved) Home Connect integration for Home Assistant
MIT License
494 stars 53 forks source link

Proces fase shows : LaundryCare.Common.EnumType.ProcessPhase.FillingDetergent #305

Closed Mitch73-2 closed 6 months ago

Mitch73-2 commented 6 months ago

Hello Ekutner,

Yesterday I saw the following log of the process phase:

So I was wondering if this is something new? I have included a photo for more clarity

Scherm­afbeelding 2023-12-28 om 15 25 52

Thank you in advance for your hard work in improving and maintaining this integration

ekutner commented 6 months ago

Sorry but I don't understand what is the issue

Mitch73-2 commented 6 months ago

It's not a problem but rather a question, sorry if I wasn't clear.

When I look at the translation, I don't see "LaundryCare.Common.EnumType.ProcessPhase.FillingDetergent" there, but I do see it in HA.

My question was actually, is this a new ProcessPhase that might need to be added to translation?

ekutner commented 6 months ago

Probably. The integration creates HA entities automatically when they are exposed by the HC API, I don't know in advance which entities are exposed by every appliance out there. The bottom line is that if the translation is missing then it should be added.

Mitch73-2 commented 6 months ago

I'll keep an eye on what other entities are exposed in the washer process phase. This week I am also getting a new Bosch dryer which also has Home Connect, so I will also keep an eye on that.

Would it perhaps be useful if I then create a Feature request with the entities found?

ekutner commented 6 months ago

Feature request is good, pull request is even better