ekvedaras
commented
4 months ago If only I would know how to address that 😄 Is your DB very big or something?
Open smirok opened 4 months ago
ekvedaras
commented
4 months ago If only I would know how to address that 😄 Is your DB very big or something?
smirok
commented
4 months ago It isn't my stacktrace and I can't get any information about the DB size, but I do expect that the user's DB is quite large)
I can say that in this case, the UI thread required a write action, but was unable to obtain a write lock, as at that time, the heavy DbReferenceResolver.resolve operation was executed inside a runReadAction call on a background thread.
I assume there is no need to call runReadAction here if read access is allowed. It might be done otherwise, if it's necessary according to the code logic.
Something like this perhaps would work:
if (!DumbService.isDumb(project)) {
if (ApplicationManager.getApplication().isReadAccessAllowed) {
TableAndAliasCollector(this).collect()
DbReferenceResolver(this).resolve()
} else { // if you need it
ApplicationManager.getApplication().runReadAction {
TableAndAliasCollector(this).collect()
DbReferenceResolver(this).resolve()
}
}
}If it doesn't help, I would suggest using cancellable read actions (see https://plugins.jetbrains.com/docs/intellij/general-threading-rules.html#read-action-cancellability) or decomposing DbReferenceResolver.resolve into several steps and calling each of them as a separate runReadAction.
ekvedaras
commented
4 months ago Thanks, very helpful 🙂 I will try your suggestion. If all checks pass, will release
smirok
commented
4 months ago One a second thought, I've realized that the code snippet from above doesn't prevent freezing, sorry for the confusion.
I definitely recommend then to use a ReadAction.nonBlocking() from https://plugins.jetbrains.com/docs/intellij/general-threading-rules.html#read-action-cancellability
ekvedaras
commented
4 months ago If I use something like this:
ReadAction.nonBlocking<Unit> {
TableAndAliasCollector(this).collect()
DbReferenceResolver(this).resolve()
}it doesn't seem to run if I call myFixture.completeBasic() in tests. What am I missing?
smirok
commented
4 months ago Does this not run only in tests or in PhpStorm too?
HenkPoley
commented
3 months ago I'm seeing PhpStorm 2024.1 (241.14494.237) hanging when editing SQL INSERT INTO VALUEs.
E.g.:
DB::insert('INSERT INTO table (t_id, name, description) VALUES (**hang when typing here**)');Disabled all downloaded plugins. Then slowly re-enabled all plugins not related to PHP, then a few of the PHP plugins, and finally the most relatedly looking (this plugin).
Still not seeing the hanging behaviour anymore. So I guess there is some race condition based on hooking ordering, influenced by what order you enabled the plugins. Still seems stable after PhpStorm restarts.
I don't think the per project .idea\laravel-query-settings.xml has any influence, since the file is unchanged since last year for me.
jayantisuthar
commented
2 months ago Facing the same issue, I can't even work 5 minutes on Phpstorm and it freezes. no click possible, can't even click or close the PhpStorm, every time force OS to close the application.
sneakyx
commented
1 month ago To the topic "race condition": for me, it seemed there is a relation between "AI Assistant" activated and not activated. When I tested the AI assistant for 7 days, I had many freezes. After the 7-days were over, my PHPStorm never freezes, regardless what I am doing. For test purposes I could activate the AI assistant again. Once activated, just less than 1 hour later I had the first freeze. Maybe it is the laravel plugin, but with more and more plugins activated the race condition seems to come more frequently.
pestretsov
commented
1 month ago Hi @ekvedaras! This is PhpStorm team again. Do you have any updates on this issue? We see more and more users reporting that Laravel Query plugin freezes the IDE completely for them.
ekvedaras
commented
1 month ago Hey, sorry, hectic life 😃 To be honest I don't have enough knowledge about the platform to know how to fix this 🙂 It seems related to ReadAction call. I also do not experience this myself :/ Granted I don't use AI assistant, just those single line completions. That read action scans code to find related statements to understand the query being built and link it to the right symbols in database. Maybe AI assistant gives the scan more work than it would need or vice versa 🤷
smirok
commented
1 month ago Hi @ekvedaras! Have you tried the suggested approach?
ekvedaras
commented
4 weeks ago Hi @ekvedaras! Have you tried the suggested approach?
Not entirely sure what it suggests apart form making it idempotent. I will try to investigate a bit more tomorrow. If you have any more pointers, happy to hear them :)
ekvedaras
commented
4 weeks ago Have published v4.0.3 with a potential fix. It should be released soon.
andreigabreanu
commented
4 weeks ago Hello, With the plugin enabled and updated to 4.0.3 + latest phpstorm, I've got a freeze almost instantly when opened a file with database queries (and refreshed the database connection). With the plugin disabled, everything works ok.
P.S. the plugin is super useful so thanks for the work you are doing on it and it would be awesome if this issue got fixed
ekvedaras
commented
3 weeks ago In order to test in later versions of phpstorm it seems like I need to do a bunch of upgrades in the plugin. Obviously various things break left and right 🙃 Might take more time
ekvedaras
commented
3 weeks ago It was mentioned I think that it may relate to AI assistant being enabled. My trial is expired so no clue how to test with it... 😄 As much as I test, everything works with no freezing 🤷
jacobp3f
commented
3 weeks ago Hi, I just wanted to share my experience with PhpStorm freezing on Ubuntu.
Whenever it's completely frozen, I use the command kill -9 $(pgrep -f phpstorm) to force it to close.
I've noticed that the freezing issue occurs specifically when I open a private Laravel library. This library includes only "illuminate/support" in its composer.json and does not have a .env file, which means there's no database connection. I often manipulate query builders in this library, and the freeze consistently occurs within files containing a $query instance. This leads me to believe that the absence of a database connection might be triggering the freezes.
Uninstalling the "Laravel Query" plugin resolved the issue for me. I hope this information proves useful.
danielpetrica
commented
3 weeks ago Hi to provide more context. I've been redirected here from reddit.
As I'm using the https://github.com/roblesterjr04/EloquentSalesForce plugin, I think this may make it crash too as If I remember correctly I've experienced these freezes only on the project where this plugin is used. Can it be that it times out because it can't reach salesforce to perform the query.
ekvedaras
commented
2 weeks ago Let's see if v4.0.4 helps
DmitrySkibitsky
commented
2 weeks ago Unfortunately it didn't work in my case. I enabled the plugin, updated it from version 4.0.2 to 4.0.4 and restarted the IDE. After clicking Refresh on the Database tab to see the new tables and interface ide hangs on all open windows. This is so sad.
ekvedaras
commented
2 weeks ago Well, I'm out of options then 😄 I cannot reproduce and clearly do not have enough knowledge about this platform nor kotlin/java dev in general to find the issue. I know the code there is not the best, but without help I don't know what else to try 🙂 Find smart friends and send them here please 🙂
smirok
commented
1 week ago @DmitrySkibitsky Hi! This is PhpStorm team once again. I was wondering if you encountered freezing issues when working with a local or remote database. Also, could you please provide me with an approximate estimate of the size of your database?
DmitrySkibitsky
commented
1 week ago @DmitrySkibitsky Hi! This is PhpStorm team once again. I was wondering if you encountered freezing issues when working with a local or remote database. Also, could you please provide me with an approximate estimate of the size of your database?
This is a local database with 400+ tables, some number of db views (less than 50). The size of databases is from 400mb to 3gb. If you need exact values, I can open a specific project that I am working on all the time, turn on the plugin, trigger a hang and provide exact values.
andreigabreanu
commented
1 week ago I can confirm it still freezes: this time I was in a class which has queries on the DB and I cmd+click a method to go to the definition. It jumped to the other file and everything froze.
Hi! PhpStorm team is here!
We noticed that PhpStorm users experience freezes when using the "Laravel Query" plugin. The stack trace of the freeze is attached below. Most likely, the
ReadActioncalled when initializingDbReferenceExpressiontakes too long.