Closed dstreett closed 6 months ago
Hello! Hopefully, this is appropriate, but I noticed a few tests were broken.
This PR represents simple API changes that were introduced in f5559c3c77f0994a22b6c1d17c8167b087c4333d.
Overview of changes:
Factor
verifier
Experiment
map_well
map_container
Container
ExperimentalSpace
substance_used
get_substanced_used
Six tests are still failing, but it might be more appropriate that they have their own PRs—they might represent bigger changes.
Let me know if you want me to squash these commits before merging or any other cleanup.
Hopefully, this is helpful - feel free to close out this PR if it isn't! Thanks!
Thanks, we'll look into this. We need to do some cleanup.
These issues will be addressed in pending refactoring.
Hello! Hopefully, this is appropriate, but I noticed a few tests were broken.
This PR represents simple API changes that were introduced in f5559c3c77f0994a22b6c1d17c8167b087c4333d.
Overview of changes:
Factor
no longer has theverifier
init parameter.Experiment
now includes theverifier
parameter.map_well
tomap_container
.Experiment
string representation to includeContainer
.ExperimentalSpace
has 'factor_rules' as init params.substance_used
toget_substanced_used
in Recipe.Six tests are still failing, but it might be more appropriate that they have their own PRs—they might represent bigger changes.
Let me know if you want me to squash these commits before merging or any other cleanup.
Hopefully, this is helpful - feel free to close out this PR if it isn't! Thanks!