ekweirui / pe

0 stars 0 forks source link

Application does not accept chinese names when it involves alot of foreigners #2

Open ekweirui opened 1 year ago

ekweirui commented 1 year ago

image.png

As a user, I would expect an hotel guest application to allow foreigners names, like chinese names because the names of these people are often in their local language, and they might not have an English name.

Thus, since the app behavior differs from user expected behavior, I classify it as a functionality bug.

In addition, I put it as medium as this is quite a huge functionality flaw, many people now can't be added into the application, and even the usage of placeholder names is not a good idea as this can be confusing to logistics and also during scenarios like police need to check guest list for criminals, defeating the purpose of the application.

nus-se-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Application does not allow certain special characters in name like é

image.png

As a user of this hotel guest management app, I would expect special characters like é to be allowed since many foreigner names like José Mourinho has such characters in them. The application allows certain symbols like hypens and periods, but important characters like é are not allowed.

Thus I feel that this is a poor design consideration and thus a feature flaw.


[original: nus-cs2103-AY2223S1/pe-interim#3841] [original labels: type.FeatureFlaw severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We agree that it would be good to include characters with accents and diacritical marks to cater to international guests. However, this is a feature that is extremely hard to implement and validate. To cater to all international guests, we would have to specify Russian, Korean, Japanese, Chinese, Urdu, etc. characters. One solution is to accept all Unicode characters, but the issue will be that emojis and non-alphabetical symbols will be accepted as well. Furthermore, names in other languages can be Romanised to the English alphabet (e.g., Jose Mourinho, Xi Jinping).

We mark this as not in scope as our time is better spent on other features.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I disagree that this is NotInScope because fixing this flaw is essential for the app to be reasonably useful. The app is used to track hotel guests, and it is extremely common for them to have non-English names. Thus, if I am unable to add some guests to the app, this is a huge restriction and really limits the user's ability to use the app.

Not being able to support the addition of other languages' names is a huge flaw as 1) There are many languages whose names have no direct translation into English 2) Not being able to track the actual guest name is non-ideal for a hotel as a hotel should have a list of full names in the event police need to check the guest list for criminals etc

Regarding the team's response "To cater to all international guests, we would have to specify Russian, Korean, Japanese, Chinese, Urdu, etc. characters.",
I feel that the problem could have been easily rectified if you (the developers) modified the target audience to be of a certain ethnicity.

image.png

For the reasons above, I feel that fixing this feature flaw is essential for the app to be reasonably useful, and for that, I reject that this should be a NotInScope.


:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: Not being able to support the addition of other languages' names is a huge flaw as 1) There are many languages whose names have no direct translation into English.
2) Not being able to track the actual guest name is non-ideal for a hotel as a hotel should have a list of full names in the event police need to check the guest list for criminals etc

image.png

Via the module website, the severity should be low when it is unlikely to affect normal operations, only appears in very rare situations, and causes a minor inconvenience.

However, this is not the case as 1) Normal operations are severely affected as adding the guest into the app is the first and foremost step before the user can do anything with the app.
2) The situation does not appear only in rare situations. It appears frequently given the context of the target audience.
3) This flaw does not pose a minor inconvenience only the reasons above (police check guest list etc)

Thus, it should be a medium severity, as it does indeed causes occasional inconvenience to the users.