ekx / GitLabAndroid

Unofficial GitLab client for Android
193 stars 62 forks source link

App crashes trying to view particular diffs (bugfix attached) #5

Closed p-schneider closed 10 years ago

p-schneider commented 10 years ago

To reproduce the issue you have to view a commit that appends code to the end of a file (in my case it was a .js file).

The app crashes trying to render "\ No newline at end of file" The line object would look like this: line.oldLine= "" line.newLine = "" line.lineContent= "\ No newline at end of file" line.lineType = null

My fix might not be the best way to fix it but at least the app doesn't crash. Returning null instead of row would also result in a crash.