search

ekzhang / sshx

Fast, collaborative live terminal sharing over the web
https://sshx.io
MIT License
5.99k stars 188 forks source link

Windows client support #87

Closed ekzhang closed 2 months ago

ekzhang commented 7 months ago

(It looks like due to a bug or some other issue on GitHub, the previous issue for Windows support is not showing up, so I'm going to make a new one.)

The sshx client is mostly cross-platform, except one file terminal.rs. To add Windows support, we would need to port terminal.rs to Windows using the ConPTY API.

thewh1teagle commented 4 months ago

Hey! What's the status of this feature?

ekzhang commented 4 months ago

You're welcome to help implement it! It's the same as before.

wll8 commented 3 months ago

Super looking forward to implementing it on Windows

ekzhang commented 3 months ago

Me too! Please give me a holler if you'd like to work on it

ekzhang commented 2 months ago

I had some time today and am mostly caught up on emails, so I went ahead and spun up a Windows VM on AWS and made a dev environment. Such a pain to even set up SSH compared to Linux! But that's what it is, remote desktop protocol and so on.

There is a PR #99 that adds Windows support to sshx. Please test and let me know if it works for you. You can build within the branch with cargo run -p sshx. Thanks!

I'm especially interested in hearing if the shell detection is working right. Powershell doesn't seem to be launching, besides that I'm just auto-detecting for git bash and cmd right now. Anything else people use commonly / stats about this? Cygwin?