search

ekzyis / CrypTool-2

Official CrypTool 2 git repository
Apache License 2.0
0 stars 0 forks source link

Check if FIXME outdated #11

Open ekzyis opened 3 years ago

ekzyis commented 3 years ago

ChaChaHashViewModel.cs:176

// FIXME There is a bug that the state update order is not as expected.
//   We need to apply previous state updates ( from the previous round ) and then the new state update.
//   But it for some reasons first applies the latest state and then the state updates fro last round in the correct order.
//   So basically like this: 4, 0, 3, 2, 1.
//   This leads to an overwrite of the diagonal.
Seq(QRIO.UpdateState(keystreamBlock, round, qr));