search

el-falso / gdlinter

This plugin runs `gdlint` on save to automatically lint your GD Script as you code.
https://godotengine.org/asset-library/asset/2520
MIT License
19 stars 5 forks source link

Source files do not conform to style guide #20

Open GTcreyon opened 3 months ago

GTcreyon commented 3 months ago

The source files for the plugin do not entirely conform to the style guide. This isn't a major issue for functionality, but it does ironically make it impossible for a project to be completely style-guide compliant while using this plugin, which seems somewhat self-defeating.

gdlint reports the following problems:

./gdLinter.gd:35: Error: Trailing whitespace(s) (trailing-whitespace)
./gdLinter.gd:38: Error: Trailing whitespace(s) (trailing-whitespace)
./gdLinter.gd:75: Error: Trailing whitespace(s) (trailing-whitespace)
./gdLinter.gd:83: Error: Trailing whitespace(s) (trailing-whitespace)
./gdLinter.gd:86: Error: Trailing whitespace(s) (trailing-whitespace)
./gdLinter.gd:89: Error: Trailing whitespace(s) (trailing-whitespace)
./gdLinter.gd:98: Error: Trailing whitespace(s) (trailing-whitespace)
./gdLinter.gd:101: Error: Trailing whitespace(s) (trailing-whitespace)
./gdLinter.gd:108: Error: Trailing whitespace(s) (trailing-whitespace)
./gdLinter.gd:114: Error: Trailing whitespace(s) (trailing-whitespace)
./gdLinter.gd:128: Error: Trailing whitespace(s) (trailing-whitespace)
./gdLinter.gd:131: Error: Trailing whitespace(s) (trailing-whitespace)
./gdLinter.gd:150: Error: Trailing whitespace(s) (trailing-whitespace)
./gdLinter.gd:174: Error: Trailing whitespace(s) (trailing-whitespace)
./gdLinter.gd:181: Error: Trailing whitespace(s) (trailing-whitespace)
./gdLinter.gd:186: Error: Trailing whitespace(s) (trailing-whitespace)
./error_descriptions.gd:5: Error: Max allowed line length (100) exceeded (max-line-length)
./error_descriptions.gd:9: Error: Max allowed line length (100) exceeded (max-line-length)
./error_descriptions.gd:10: Error: Max allowed line length (100) exceeded (max-line-length)
./error_descriptions.gd:12: Error: Max allowed line length (100) exceeded (max-line-length)
./error_descriptions.gd:13: Error: Max allowed line length (100) exceeded (max-line-length)
./error_descriptions.gd:14: Error: Max allowed line length (100) exceeded (max-line-length)
./error_descriptions.gd:18: Error: Max allowed line length (100) exceeded (max-line-length)
./error_descriptions.gd:22: Error: Max allowed line length (100) exceeded (max-line-length)
./error_descriptions.gd:23: Error: Max allowed line length (100) exceeded (max-line-length)
./error_descriptions.gd:24: Error: Max allowed line length (100) exceeded (max-line-length)
./error_descriptions.gd:25: Error: Max allowed line length (100) exceeded (max-line-length)
./error_descriptions.gd:26: Error: Max allowed line length (100) exceeded (max-line-length)
./error_descriptions.gd:31: Error: Max allowed line length (100) exceeded (max-line-length)
./error_descriptions.gd:49: Error: Max allowed line length (100) exceeded (max-line-length)
./error_descriptions.gd:50: Error: Max allowed line length (100) exceeded (max-line-length)
./UI/Name.gd:31: Error: Max allowed line length (100) exceeded (max-line-length)
./UI/Dock.gd:54: Error: Trailing whitespace(s) (trailing-whitespace)
./UI/Dock.gd:59: Error: Trailing whitespace(s) (trailing-whitespace)
./UI/Dock.gd:81: Error: Trailing whitespace(s) (trailing-whitespace)
Failure: 35 problems found

In addition to the problems listed above, file names in the project source use inconsistent casing conventions. The style guide suggests using snake_case for file names.