el-falso / gdlinter

This plugin runs `gdlint` on save to automatically lint your GD Script as you code.
https://godotengine.org/asset-library/asset/2520
MIT License
19 stars 5 forks source link

Can't find gdlint #7

Closed eldyer closed 7 months ago

eldyer commented 7 months ago

The problem happens with 2.0.0 from the AssetLib but also with current master.

Version 1.0.1 still works.

I'm using Godot 4.3.dev5.

el-falso commented 7 months ago

Thank you for reporting, it's a known issue and someone has also a fix for it in https://github.com/el-falso/gdlinter/issues/4#issuecomment-2011405458. I'll push out the fix when I'm on the PC again.

eldyer commented 7 months ago

I'm on linux and still get the error with 2.0.1. I'll see if I can find out where the problem is.

eldyer commented 7 months ago

So the problem seems to be in get_gdlint_path. In my case it returns ~/.local/bin/gdlint, but it's not there, it's at /usr/bin/gdlint in my case. Returning just "gdlint" as for windows works for me.

el-falso commented 7 months ago

Thank you for reproducing the issue. Seems like it's more difficult to get the path to gdlint for various operating systems and for various different installations than I thought.

Hope #10 fixes it this time, since I added two fallbacks.

eldyer commented 7 months ago

:+1: it's working now.

Thanks for creating this awesome plugin!

el-falso commented 7 months ago

Great, thank you really much for your kind words. ❤️

I really hope this issue will be fixed forever now, since I'm really out of solutions. 😅