el-hoshino / NotAutoLayout

Layout your views without Auto Layout constraints, in a much more swifty way.
http://qiita.com/lovee/items/7454c9f27638a8e471fa
Apache License 2.0
179 stars 8 forks source link

iOS Deployment Target 11.0 #142

Closed ykws closed 3 years ago

ykws commented 3 years ago

fixes #141

ykws commented 3 years ago

@el-hoshino Please check target OS on Bitrise, I guess remain to support iOS 9.

el-hoshino-bitrise commented 3 years ago
3 Warnings
:warning: Sources/NotAutoLayout/Extensions/UIView.swift#L34 - FIXMEs should be resolved (Get this property without Auto…).
todo UIView.swift:34
:warning: Sources/NotAutoLayout/Extensions/UIView.swift#L87 - FIXMEs should be resolved (Get this property without Auto…).
todo UIView.swift:87
:warning: Sources/NotAutoLayout/NotAutoLayoutCompatible/NotAutoLayoutCompatible.swift#L11 - Sources/NotAutoLayout/NotAutoLayoutCompatible/NotAutoLayoutCompatible.swift#L11: using 'class' keyword to define a class-constrained protocol is deprecated; use 'AnyObject' instead
public protocol NotAutoLayoutCompatible: class {
2 Messages
:book: Executed 26 tests, with 0 failures (0 unexpected) in 15.681 (15.709) seconds
:book: What a good PR :white_flower:

Develop PR Check Result

Item Result
Head Branch check :o:
Base Branch check :o:
Merge Commits check :o:
Modification Volumn check :o:

Generated by :no_entry_sign: Danger

el-hoshino commented 3 years ago

@ykws Sorry, could you please close this PR and remake another PR to develop with the same head branch? I tried to close and re-open this PR but somehow it just doesn't ignore the merge commits, which should already be included in develop 🤔

ykws commented 3 years ago

@el-hoshino Thank you for review. I force pushed remake PR from develop branch, before from master branch.