el1t / uBlock-Safari

uBlock Origin - An efficient blocker for Chromium, Firefox, and Safari. Fast and lean.
GNU General Public License v3.0
2.75k stars 97 forks source link

The popup button and the user interface aren't reset when one goes to different website on the same window/tab #114

Open gkarag opened 6 years ago

gkarag commented 6 years ago

Describe the issue

Say I open a Safari tab and visit a web site e.g. github.com. Then using the bookmarks or from the address field i visit another site using the same window/tab, e.g. reddit.com. The counter on the uBlock popup button and the advanced user interface show me the statistics and URL's of blockable content from both github.com and reddit.com. (Update) The plugin also keeps displaying the on/off state from the first site.

One or more specific URLs where the issue occurs

No specific URLs.

Screenshot in which the issue can be seen

screen shot 2018-04-24 at 15 36 13 screen shot 2018-04-24 at 15 36 56

Steps for anyone to reproduce the issue

  1. Switch to advanced user mode
  2. Open a tab/window and go to github.com
  3. Click the uBlock button and check what is blocked
  4. Then on the same window/tab visit reddit.com
  5. Again click the uBlock button
  6. Links in github show on the blockable content pane.

Your settings

"userSettings": { "advancedUserEnabled": true, "alwaysDetachLogger": false, "autoUpdate": true, "cloudStorageEnabled": false, "collapseBlocked": true, "colorBlindFriendly": false, "contextMenuEnabled": true, "dynamicFilteringEnabled": true, "externalLists": "https://raw.githubusercontent.com/reek/anti-adblock-killer/master/anti-adblock-killer-filters.txt\nhttps://mirror1.malwaredomains.com/files/immortal_domains.txt\nhttps://raw.githubusercontent.com/liamja/Prebake/master/obtrusive.txt\nhttps://easylist-downloads.adblockplus.org/bitblock.txt\nhttps://raw.githubusercontent.com/jspenguin2017/uBlockProtector/master/uBlockProtectorList.txt", "firewallPaneMinimized": true, "hyperlinkAuditingDisabled": true, "ignoreGenericCosmeticFilters": false, "largeMediaSize": 50, "parseAllABPHideFilters": true, "prefetchingDisabled": true, "requestLogMaxEntries": 1000, "showIconBadge": true, "tooltipsDisabled": false, "webrtcIPAddressHidden": false },

Your filter lists
Your custom filters (if any)
LesterJitsi commented 6 years ago

Same here.

fostermarke commented 6 years ago

Same problem here too. The problem is present in normal user mode (i.e. not Advanced) too. The counter and list just keep growing with elements from each successive pages added. It is not confined to any particular sites. All seem to be affected.

ETA: I have reverted to 1.15.4 until fixed.

0xC0FFEEADD1C7ED commented 6 years ago

I'm having the same issue since updating the other day. Things seem really badly borked.

If I move back to the previous version will I retain all of my configuration and filters? I can't back up because the export config button doesn't seem to work for me, and it's taken a looong time to get the filtering fully working for me gradually as I visit sites, so I'd hate to lose it all.

0xC0FFEEADD1C7ED commented 6 years ago

Never mind the above. I went poking around in my preferences directory and found the settings in safari.extensions.plist (or something to that effect) and backed it up first before rolling back. No problems. I should have really done this before posting the first time.

Jack15911 commented 6 years ago

Same with mine, also MacOS 10.13.4 and Safari 11.1. I get a huge number of "Requests blocked on this page," perhaps 700 to 900. Past URLs clear at random or after I have restarted Safari. That number makes it very difficult to fix a broken page.

screen shot 2018-05-16 at 7 33 46 am

Edited to add: Reverting to version 1.15.4 appear to have cleared the problem and I was able to restore my settings with no problem.

Forcer78 commented 6 years ago

Updated earlier today on macOS 10.12.6. This totally breaks the extension and I'm shocked the issue has been known for almost a month.

gpderegil commented 6 years ago

I can confirm I'm experiencing this bug too, using Safari 11.2 in MacOS 10.13.4 and also when using the latest Safari Technology Preview (Release 56 (Safari 11.2, WebKit 13606.1.17.2.2)). Have tried using stock filter lists as well as my regular ones but it makes no difference at all. Past version of the extension works correctly.

kimonostereo commented 6 years ago

Had the same issue. Reverted to previous version and that fixed it.