search

el1t / uBlock-Safari

uBlock Origin - An efficient blocker for Chromium, Firefox, and Safari. Fast and lean.
GNU General Public License v3.0
2.75k stars 97 forks source link

Unable to save site-specific changes ('make changes permanent') since release 1.16.0 [Safari 11.1, OS High Sierra 10.13.4] #118

Open floriandierickx opened 6 years ago

floriandierickx commented 6 years ago

Describe the issue

When trying to save a site-specific rule (by changing rules in the column options), I am unable to save them (the lock-icon appears but does not respond when clicking on it). When closing the site and re-opening it in a new tab or window, the rules seem not to be saved and need to be changed again.

One or more specific URLs where the issue occurs

For example: https://alternativeto.net (or any other website)

Screenshot in which the issue can be seen

screen shot 2018-05-15 at 15 32 05

Steps for anyone to reproduce the issue

  1. Open website
  2. Make changes to site-specific rules
  3. Try to save (lock-icon) -> does not react
  4. Close website
  5. Reload website in new screen/tab: changes to site-specific rules do not seem to be saved

Your settings

Your filter lists

all

Your custom filters (if any)

12 site-specific filters (those were much more before: did the list get deleted with the update?)

ghost commented 6 years ago

I have the same problem but there is a workaround: You can save your site-specific rules permanently over "Dashboard --> My Rules"

SebastianRasch commented 6 years ago

Can confirm this issue. Same applies for the eraser icon to reset settings to the previous state.

samhoosh commented 6 years ago

Can also confirm this issue. (Touchbar MBP 15). Another thing that might be connected to this: dynamic filtering has simply ceased to work in Safari. Local noop rules are ignored, everything remains blocked, even though I'm only using the basic default lists, which is all I have after my previous custom lists and rules were deleted and reset to zero with the update. I never thought to backup! This cumulatively has been so disheartening that I've gone back to Firefox, where ublock in hard mode works flawlessly.

luispuerto commented 6 years ago

The same here!

pieterdd commented 6 years ago

Same. I can't press the lock button to save rule changes.

eproxus commented 6 years ago

Inspecting the plug-in code, the following error occurs in the console when pressing the commit button:

TypeError: desHostnames.hasOwnProperty is not a function. (In 'desHostnames.hasOwnProperty(desHostname)', 'desHostnames.hasOwnProperty' is undefined)

postMessage — vapi-client.js:396
nathan78906 commented 6 years ago

This is still happening.

datkush420 commented 6 years ago

Updated to Safari 12.0 and I'm experiencing this issue from both the Extension Gallery & manual download of .safariextz file installed with Extension Builder.

macOS 10.13.6 uBlock Origin 1.16.0

-Edit- Downgrading to version 1.15.4 restored functionality. I'll stick with that for now.

Wayneoween commented 5 years ago

Still an issue.

macOS 10.14.2

1.15.4 of uBlock Origin works. Thanks @datkush420