el1t / uBlock-Safari

uBlock Origin - An efficient blocker for Chromium, Firefox, and Safari. Fast and lean.
GNU General Public License v3.0
2.75k stars 98 forks source link

Catalina compatibility #156

Open pderiy opened 5 years ago

pderiy commented 5 years ago

Doesn't work with macOS Catalina Beta 2.

It just removes this plugin.

MoOx commented 5 years ago

New Safari that comes with macOS 10.15 seems to only accepts extensions from the App Store.

Related to #151 & #149

newmediacrew commented 5 years ago

Have been playing around with Catalina. And this is indeed the case. In Safari 12 you are still able to download and install it via https://safari-extensions.apple.com/details/?id=com.el1t.uBlock-3NU33NW2M3

For safari 13 the installation button is missing

levicki commented 5 years ago

@el1t

I can confirm this. Safari 13 disables the extension and you can no longer install it.

While this issue is ignored, people are already installing uBlock instead of uBlock Origin:

image

https://apps.apple.com/us/app/ublock/id1385985095?mt=12

I can't see @gorhill being happy about that.

freediverx commented 5 years ago
  1. This has been known for a long time already. The fact that you just discovered it doesn’t make it newsworthy. Try reading up past comments on a topic before posting your own.

  2. Nobody is “ignoring” the issue. Apple locked down Safari extensions to the point where it is impossible to recreate uBlock Origin’s functionality.

  3. Anyone installing “uBlock” (non-origin) is an idiot, since that is a copy-cat product published by a scumbag without the ethics or principles of uBlock Origin’s original creators. https://www.reddit.com/r/uBlockOrigin/comments/9xywfy/ublockllc_taking_code_from_ublock_origin_without/ https://www.reddit.com/r/uBlockOrigin/comments/9xywfy/ublockllc_taking_code_from_ublock_origin_without/ Can’t wait for the complaints when this users discover down the road that the app was a vector for malware and spyware.

On Jul 1, 2019, at 3:45 AM, Igor Levicki notifications@github.com wrote:

I can confirm this. Safari 13 disables the extension and you can no longer install it.

While you are ignoring this issue, people are installing uBlock instead of uBlock Origin: https://user-images.githubusercontent.com/16415478/60419155-e77ba680-9be4-11e9-9ebc-1966021c5250.png — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/el1t/uBlock-Safari/issues/156?email_source=notifications&email_token=ABG2XKYEKGU254L32S225BTP5GYZ5A5CNFSM4HZIFS2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY5JAMY#issuecomment-507154483, or mute the thread https://github.com/notifications/unsubscribe-auth/ABG2XK2C4DYIUJNHSCLTRZDP5GYZ5ANCNFSM4HZIFS2A.

levicki commented 5 years ago

@freediverx

  1. I have read previous comments. If someone relevant finds my comments unproductive they are free to delete them and you are free to ignore them. In any case there is no need to be rude and call people who know less than you idiots.

  2. I have known since Mojave Beta that Apple wants to kill old type of powerful extensions in favor of much more limited content blockers. However, they now also offer Safari App Extensions and they even offer a Legacy Extension to Safari App Extension conversion guide. To me that looks like a way forward, since that seems how uBlock LLC and others are working around the Content Blocker extension limits.

  3. I am using uBlock Origin long enough on all platforms to know the difference between it and the uBlock LLC. What I wanted to point out is that other people might not know, not care enough, or just need some alternative (however bad it is still better than having no ad blocker at all) which uBlock LLC is currently providing and this project is not.

From what I see on the issue tracker this projecct seems to be dead for at least a year. It would be fair if @el1t came out of retirement long enough to at least publicly declare its fate.

Hopefully someone else will pick up the mantle soon and do what's needed to make it compatible with Safari again.

sammcj commented 5 years ago

Out of interest and not wanting to start a flame war, while I use Firefox as my main browser which ublock works wonderfully with, safari is handy at times - what do people recommend as the best 'advanced' ad blocker that works with safari from the safari extension store thing?

translit commented 5 years ago

AdGuard. Free, open-source, many lists, element blocker.

freediverx commented 5 years ago

Extremely slow and sluggish. Requires a Mac application running in the background.

On Jul 5, 2019, at 12:11 PM, translit notifications@github.com wrote:

AdGuard. Free, open-source, many lists, element blocker.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/el1t/uBlock-Safari/issues/156?email_source=notifications&email_token=ABG2XK6BKYWGBPQAH7AMKULP55XEJA5CNFSM4HZIFS2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZJ4FYQ#issuecomment-508805858, or mute the thread https://github.com/notifications/unsubscribe-auth/ABG2XKYCZROGS7SPLVOIUTTP55XEJANCNFSM4HZIFS2A.

newmediacrew commented 5 years ago

Extremely slow and sluggish. Requires a Mac application running in the background. On Jul 5, 2019, at 12:11 PM, translit @.***> wrote: AdGuard. Free, open-source, many lists, element blocker. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#156?email_source=notifications&email_token=ABG2XK6BKYWGBPQAH7AMKULP55XEJA5CNFSM4HZIFS2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZJ4FYQ#issuecomment-508805858>, or mute the thread https://github.com/notifications/unsubscribe-auth/ABG2XKYCZROGS7SPLVOIUTTP55XEJANCNFSM4HZIFS2A.

Its a "thing" with all these adblockers that support safari 13. They indeed run as seperate application in the background. I wonder if this is going to be the standard for safari 13 and onwards. That really would suck.

freediverx commented 5 years ago

I’m frustrated that 1) Apple seems to have killed a lot of useful extensions with these changes and 2) none of the tech pundits seem to be writing about it (probably because most of them are enslaed pithing Google’s ecosystem anyway.)

Without a strong enough public backlash, Apple has no pressure to fix what they’ve broken.

On Jul 5, 2019, at 12:35 PM, Jeroen notifications@github.com wrote:

Extremely slow and sluggish. Requires a Mac application running in the background. … <x-msg://3/#> On Jul 5, 2019, at 12:11 PM, translit @.***> wrote: AdGuard. Free, open-source, many lists, element blocker. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#156 https://github.com/el1t/uBlock-Safari/issues/156?email_source=notifications&email_token=ABG2XK6BKYWGBPQAH7AMKULP55XEJA5CNFSM4HZIFS2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZJ4FYQ#issuecomment-508805858>, or mute the thread https://github.com/notifications/unsubscribe-auth/ABG2XKYCZROGS7SPLVOIUTTP55XEJANCNFSM4HZIFS2A https://github.com/notifications/unsubscribe-auth/ABG2XKYCZROGS7SPLVOIUTTP55XEJANCNFSM4HZIFS2A.

Its a "thing" with all these adblockers that support safari 13. They indeed run as seperate application in the background. I wonder if this is going to be the standard for safari 13 and onwards. That really would suck.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/el1t/uBlock-Safari/issues/156?email_source=notifications&email_token=ABG2XK2RNWHAUXYGFOBTCY3P55Z4FA5CNFSM4HZIFS2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZJ5ORI#issuecomment-508811077, or mute the thread https://github.com/notifications/unsubscribe-auth/ABG2XKZI7FLGSI5NBXDFGD3P55Z4FANCNFSM4HZIFS2A.

levicki commented 5 years ago

All new Safari extensions require application to be installed at all. That's the way forward and Apple is not going to change their mind on their API nor they will give up on requiring extensions to get installed along with an app through the store only.

Sadly, they are right. While you can install an .xpi into your Firefox from anywhere as long as it is signed, Mozilla is struggling to keep people safe from malicious extensions because of this side-loading ability. Apple doesn't want to deal with that, extension must pass review just like any other app you are letting on your system because at the end of the day we are granting it full access to everything you do in your browser -- that's a huge amount of trust that we place in a third party developer every time we install an extension.

On the other hand, Apple is wrong when it comes to content blockers. They should include even more advanced filtering like uBlock and uMatrix and remove the rule number limit, but even if they do that in the next API version I am sure they won't remove the companion app requirement which to me, makes sense because it brings extensions on the same level of visibility and responsibility as the rest of the software.

beez1717 commented 5 years ago

I absolutely hate that apple has made it so that it is impossible to use ublock origin and other similar extensions that help keep you safer, speed up the internet, and even stop malicious redirects to scams or pages that try and fake a system error. I hope people find a workaround.

lostinlodos commented 5 years ago

I believe I MAY have found one but I haven’t tried it yet. Using the developer menu you can build out an extension from a previous version. It’s worth a look.

ultratiem commented 5 years ago

@sammcj 1Blocker. The fastest and most reliable content blocker. Adguard requires a subscriptions and most of the other cheap little content blockers don't do much of anything other than take your money. I've tried most, wipr, ka-block, ghostery, etc.

Nothing is going to be as expansive as uBlock Origins, but it's definitely the best one out there.

lostinlodos commented 5 years ago

@ultraTiem Any chance it allows object blocking? My principal use of ubo is the block object feature. Be it an annoying script box on amazon for suggestions that are always poor, or tracking films from Netflix I’ve seen by blocking the cover image. ;)

I generally whitelist adverts and block annoying ones as I find them manually. Like some computer sites that demand to load videos throughout an article. I’ve yet to find an app based blocker that can do that.

alaborie commented 5 years ago

AdGuard. Free, open-source, many lists, element blocker.

Maybe it's me, but I would not enable a content blocker that can read my passwords or credit card info...

Screen Shot 2019-07-20 at 9 11 42 am
albertoramires commented 5 years ago

AdGuard. Free, open-source, many lists, element blocker.

Maybe it's me, but I would not enable a content blocker that can read my passwords or credit card info...

Screen Shot 2019-07-20 at 9 11 42 am
Screenshot 2019-07-20 at 14 15 41

uBlock requests the same exact permissions, it's necessary for these ad blocking extensions to function.

Does AdGuard have a free alternative for OSX though?

ultratiem commented 5 years ago

@lostinlodos yes, it’s possible.

I think most people don’t know that uBu cannot exist in its current state as a Safari extension. The current extensions can do nothing more than pass a simple, passive list to the browser. It’s the most primitive way of adblocking.

lostinlodos commented 5 years ago

I’m finding all sorts of issues trying to rebuild the code to the new format for Catalina. Apple made a LOT of changes on options and permissions. And all I keep getting on the build end is garbage. I’m not a ‘real’ developer by any stretch... but updating this to the new safari extensions store is not going to be quick for the real development team. Unfortunately. They can always use a buy-in approach to cover the work. The few extensions that have made the jump, a bunch are now buy-in and doing well! At $1.99 and $4.99, I’d bet a pleasant surprise on the number of us willing to pay if it fully works again. I’ll try 1blocker... for now. But I’d like to see UBO move forward.

newmediacrew commented 5 years ago

I’m finding all sorts of issues trying to rebuild the code to the new format for Catalina. Apple made a LOT of changes on options and permissions. And all I keep getting on the build end is garbage. I’m not a ‘real’ developer by any stretch... but updating this to the new safari extensions store is not going to be quick for the real development team. Unfortunately. They can always use a buy-in approach to cover the work. The few extensions that have made the jump, a bunch are now buy-in and doing well! At $1.99 and $4.99, I’d bet a pleasant surprise on the number of us willing to pay if it fully works again. I’ll try 1blocker... for now. But I’d like to see UBO move forward.

You are not the only one. The reason i use ublock origin is the custom things you can do with it. And this one works well on twitch blocking 99% of all ads / prerolls.

I gladly pay 5 bucks for an app that works like ublock origin in safari 13.

Does adguard work on twitch by blocking ads and prerolls ?

ghost commented 5 years ago

It is not possible for a traditional adblocker to work in Safari on Catalina. Neither uBlock Origin, uBlock, Adblock Plus, Adblock or anything else will work. The adblockers in Catalina Safari (or safari on iOS) have to use safaris Content Blocking API. This means that every adblocker has the same resource usage and the same speed and have to be Mac apps. The only difference between them is that they have different lists. The extension / app called "ublock" for safari is not infact ublock. It contains code from either ublock or ublock origin. It is just a simple content blocking app bundled worth easy list and ABPs acceptable ads.

If you want adblocking on Mac I recommend you either get Firefox and install uBlockOrigin, or get 1blocker (content blocker with the greatest customization) or Adguard for safari (content blocker with greatest blocking power). Both are avaliable on the Mac app store.

lostinlodos commented 5 years ago

I moved to 1blocker for safari. The level of customisation is godlike. It’s/almost/ as good as UB/UBO. It just takes more steps to do the same thing. Downside is it’s hit and miss on element blocking. It picks the top displayed area, not the top rendering layer. So sites like IMDB with their massive distracting wallpapers can’t block the wallpaper without destroying the page functionality. On the plus it did work to trim down all the garbage frames on amazon that are buggy and cause crashes in any MacOS browser if you use it enough. It’s an idea for this project. To build the app processes and go through the trouble. 1blocker exploded with Catalina testers! If it can be done before the R1 version of Catalina you could recover the market and bring in some profits.