el1t / uBlock-Safari

uBlock Origin - An efficient blocker for Chromium, Firefox, and Safari. Fast and lean.
GNU General Public License v3.0
2.75k stars 97 forks source link

Advanced user not disabling #27

Open Baccount opened 7 years ago

Baccount commented 7 years ago

Read first: https://github.com/gorhill/uBlock/blob/master/CONTRIBUTING.md

Describe the issue

When I enable advanced user mode and then disable the option, it stays in a enabled advanced mode.

One or more specific URLs where the issue occurs

[URL(s) for issue on a specific site are mandatory] every url is effected

Screenshot in which the issue can be seen

[Screenshot(s) for visual issues are mandatory]

Steps for anyone to reproduce the issue

Open block settings and enable advanced user then disable it, and it will stay enabled no mater what the setting is set to. Click on the unlock icon and it will still be shown in advanced mode.

Your settings

[If you fail to provide this info, I will mark the issue as invalid. Lists all settings which differs from default settings]

Your filter lists

Default filters are set

el1t commented 7 years ago

Hmm, I can't seem to reproduce this issue. If you're referring to the popup still showing the dynamic filter grid, that's expected behavior—simply click on "Requests Blocked" to hide it. However, when you disable advanced filters, the dynamic filters you select within the UI will be ignored, though uBlock will remember them for the next time you enable advanced filters. For more info, check out the wiki page.

gorhill commented 7 years ago

https://github.com/gorhill/uBlock/releases/tag/1.10.0.