the "+/- all" expand domains toggle keeps flipping to expand

el1t / uBlock-Safari

uBlock Origin - An efficient blocker for Chromium, Firefox, and Safari. Fast and lean.

GNU General Public License v3.0

2.75k stars 98 forks source link

the "+/- all" expand domains toggle keeps flipping to expand #46

Open TheIronBorn opened 7 years ago

TheIronBorn commented 7 years ago

If I toggle to "don't expand domains", close the popup, then open it again: the toggle is set instead at "expand all domains". This occurs even while loading a page, open the popup, toggle to collapse, the toggle is then flipped back with the popup open.

MacOS version: 10.12.5
Safari version: Release 30 (Safari 10.2, WebKit 12604.1.22)
uBlock Origin version: v1.11.3.1

gorhill commented 7 years ago

@elt uBO uses the window.localStorage of the extension to save these visual settings -- this suggests this storage is not available for Safari? Or maybe there is a setting some users may have which prevents writing to it.

TheIronBorn commented 7 years ago

This makes some sense since this has since stopped happening. Unsure what setting I might have set to fix it but I'll try some stuff.

5t3f4n commented 7 years ago

Not sure if this is related but I just performed a clean install of uBlock-Safari 1.12.5b and afterwards I noticed that the state of the +/- toggle in the 3rd-party filters tab was saved. I'm pretty sure the default state is to show all filter lists and not just subscribed ones. I even ran "Reset to default settings…" before uninstalling, restarting and re-installing.

There seems to be some wonkiness in general when it comes to +/- toggles.

macOS 10.12.5 (16F73) Safari 10.1.1 (12603.2.4) uBlock-Safari 1.12.5b