el1t / uBlock-Safari

uBlock Origin - An efficient blocker for Chromium, Firefox, and Safari. Fast and lean.
GNU General Public License v3.0
2.75k stars 98 forks source link

Safari can’t install this extension #86

Closed david-macrae closed 6 years ago

david-macrae commented 6 years ago

Filter issues MUST NOT be reported here. Read first: https://github.com/gorhill/uBlock/blob/master/CONTRIBUTING.md

Describe the issue

the latest build 1.14.24 that was just uploaded will not install.

safari just pops up with a warning: Safari can’t install this extension

One or more specific URLs where the issue occurs

[URL(s) for issue on a specific site are mandatory]

Screenshot in which the issue can be seen

[Screenshot(s) for visual issues are mandatory]

Steps for anyone to reproduce the issue

  1. Be as detailed as possible:
  2. Because we are not looking over your shoulder and
  3. Keep in mind: Nobody can read your mind.

Your settings

[If you fail to provide this info, I will mark the issue as invalid. Lists all settings which differs from default settings]

Your filter lists

[Example: "Default filter lists + FRA", or "Default filter lists minus uBlock -- Badware risks"]

Your custom filters (if any)
ghost commented 6 years ago

Yeah same here, and the update button in Safari Extension Updates does nothing.

Baccount commented 6 years ago

Im also effected running macOS 10.13.2 (17C205) Safari 11.0.2

danmcquade commented 6 years ago

Same issue here. Tried on two different Macs, both running 10.13.2 (17C205) with Safari 11.0.2.

screen shot 2018-01-18 at 7 20 01 pm

mustii82 commented 6 years ago

same problem :/

ruchernchong commented 6 years ago

macOS Version: macOS 10.13.3 Beta 4 (17D39a) Safari Version: Version 11.0.3 (13604.5.6)

Description:

Unable to install the extension for 1.14.24

sheelgautam commented 6 years ago

macOS Version 10.13.2 (17C205) Safari Version 11.0.2 (13604.4.7.1.6)

Can install Ub0 1.14.14 but cannot install 1.14.24. Error : Safari can't install this extension. Can install other extensions in addition to extensions from Safari Extension Gallery.

MysticalOS commented 6 years ago

Won't install or upgrade from gallery in safari or tech preview. it just rejects .24 version

maciboy commented 6 years ago

Same :/

volcbs commented 6 years ago

Wow, I thought I was the only one. Got the same problem here. MacOS 10.12.6 Safari 11.0.2

gorhill commented 6 years ago

Did any of you try what was suggested in https://github.com/el1t/uBlock-Safari/issues/85#issuecomment-357420212?

Run sudo softwareupdate -i -a in terminal and it should install any updates.

danmcquade commented 6 years ago

Did any of you try what was suggested in #85 (comment)?

Tried this on both of my machines. Both are fully up to date and 1.14.24 still fails to install.

manuseoane commented 6 years ago

Same here on Safari 11.0.2, macOS 10.11.6.

Maybe an issue related to Safari >= 11.0.2?

maciboy commented 6 years ago

@gorhill No updates are available for my system

vassudanagunta commented 6 years ago

@MysticalOS @sheelgautam The unauthorized build has been reported to have finally been removed from the extensions gallery. Are you still finding it there?

sheelgautam commented 6 years ago

@vassudanagunta Nope. I meant that I could install other extensions from the Extensions Gallery. Ublock Origin is not on it. My earlier comment probably caused confusion.

fostermarke commented 6 years ago

Extension won't install here either. Clicking update in the prefpane does nothing and downloading to install manually produces the error dialog show earlier. This is Safari 11.0.2 on both 10.13.2 and 10.11.6.

dnblankedelman commented 6 years ago

I have yet to try and reproduce this, but I am curious (in an attempt to help the developers who I really appreciate): when this fails, any messages at all in the OSX console, Safari web inspector/console, some other log source? Any useful info from Xcode or the Extension builder in the Develop menu (have to turn it on in preferences)?

Just wondering if Safari logs any more useful info any place else beyond a "it be broke" dialogue.

mamedker commented 6 years ago

Same there but nevertheless, thanks for the great work !

Hope it'll be fixed soon

sidneys commented 6 years ago

same here, neither update nor fresh install works.

iAYMANi commented 6 years ago

Same issue here

timbuktu234 commented 6 years ago

Exactly same problem as original poster. Extension fails to install.

Running macOS 10.13.2 (17C205) Safari Version 11.0.2 (13604.4.7.1.6) on MacBook Pro Mid 2014

screen shot 2018-01-19 at 10 52 23 am
SLGiHub commented 6 years ago

Yeah same here after following manual install instructions, fails to install

marcothuemmler commented 6 years ago

./tools/make-safari.sh all and installing through the Extension builder seems to have done the trick for me.

bildschirmfoto 2018-01-20 um 09 31 17 bildschirmfoto 2018-01-20 um 09 21 33 bildschirmfoto 2018-01-20 um 09 22 05
ghost commented 6 years ago

Can it be repackaged and added to releases?

volcbs commented 6 years ago

@megadr01d You need to have the certificate, but then it won't be upgradeable to the next version (IIRC). So @el1t should be the one who does it.

CasualDeveloper commented 6 years ago

Just wanted to say I'm having this issue too

accolon commented 6 years ago

./tools/make-safari.sh all and installing through the Extension builder seems to have done the trick for me.

It even works if you extract the downloaded uBlock0.safariextz (with xar -xf) and then install it through Extension Builder. It's a shame Safari doesn't provide any additional information what's wrong, or I'm looking in the wrong places.

Besides, the problem exists on both Safari versions right before and after the Meltdown/Spectre patches, while build 1.14.14 still works.

maciejtarmas commented 6 years ago

Safari shows a pending update, but you can click the "Update" button to death and nothing happens.

Trying to install the new version manually results in the message like in the OP's bug report.

If only Firefox was as battery efficient as Safari, I'd switch in a sec.

Apple is going downhill with their QA lately. I'm seriously considering switching to Windows or Linux after years of being an Apple loyalist.

macOS 10.13.2 Safari 11.0.2 (13604.4.7.1.6)

screen shot 2018-01-20 at 23 02 07
ghost commented 6 years ago

Hello, I can confirm the update is showing as per maciejtarmas, looks like there is no action on the 'Update' button. However this is a issue with the signature. Safari is throwing a:

"CSSM Exception: -2147415734 CSSMERR_CSP_VERIFY_FAILED" in the console.app

safari-ublock-update-log.txt

volcbs commented 6 years ago

^ from this https://developer.apple.com/library/content/technotes/tn2318/_index.html

If OCSP and CRL checking are temporarily turned off (in Keychain Access > Preferences > Certificates) and this resolves the Xcode build, reinstall Xcode (to restore its own signature) and also ensure there are no network connectivity issues on the Mac that is running Xcode.

ghost commented 6 years ago

volcbs,

I do totally agree however the previous version 1.14.14 is being installed manually from the Release repo (https://github.com/el1t/uBlock-Safari-releases) and it is not showing the CSSM issue on install. It is only 1.14.24 which seems to be not properly signed. Most likely 99% of the ublock origin users on safari do not even have Xcode installed or any other build tools.

ghost commented 6 years ago

I contacted the dev by email on the 19th but no dice, I told him to look at this thread.

PTDennis commented 6 years ago

Another one having the same issue. Hope the dev will release an update soon.

vassudanagunta commented 6 years ago

FYI: Please everyone remember @el1t does this port of uBlock Origin to Safari all on his own time, unpaid, and with little credit. And he's clearly busy. And no one else is stepping up to help maintain the port. On top of that some other user made his life more difficult (#69) and is the reason the Extension Gallery version is a problem.

(feel free to vote up #71 to show some love)

ghost commented 6 years ago

Excellent point @vassudanagunta . We've been using 1.14.14 for months so we can wait for x.24 to get sorted at elt's convenience while still browsing with a good extension.

nidstigator commented 6 years ago

Adding my voice to these appreciating all the work @el1t is doing!

The $99/year fee alone has been the reason most devs stayed away from porting uBlock to Safari.

gingerbeardman commented 6 years ago

Also getting this.

Could it be released to the fact that it has also disappeared from the Safari Extensions Gallery?

hmage commented 6 years ago

I'm getting this too.

No xcode, OSX 10.13.2, Safari 11.0.2 (13604.4.7.1.3).

uBlock 1.14.14 installs fine even after removing it and adding it back.

agottardo commented 6 years ago

Getting this too on 11.0.2 (13604.4.7.1.6).

gingerbeardman commented 6 years ago

Thanks for the info @vassudanagunta ! I had no idea the Safari extension gallery version was unauthorised.

el1t commented 6 years ago

Sorry everyone, looks like the build script produced a bad extension. I've rebuilt it using Safari's extension builder, and it installs for me: uBlock0.safariextz.zip (unzip first). I'll update the release if the issue is fixed.

The build might have failed due to a renewed certificate or the archive signing method becoming outdated—either way, I'll make sure to verify installation works next time.

dart-h-vader commented 6 years ago

@maciejtarmas Though I acknowledge there is an issue with the extension, it is for the benefit of the users that the extension is failing to install. Granted, uBlock is a genuine piece of software but the signing is an essential step for keeping malicious extensions at bay.

ghost commented 6 years ago

It auto-updated from 1.14.14 for me after your post. Thanks for your work @el1t

gingerbeardman commented 6 years ago

update from within safari worked for me just now. thanks

el1t commented 6 years ago

Great! I'll close this issue since it looks fixed.

timbuktu234 commented 6 years ago

Extension working now, thank you!

volcbs commented 6 years ago

Thank you!

lsunsi commented 6 years ago

Thank you dude!

maelcum commented 6 years ago

Thank you!

ghost commented 6 years ago

@nidstigator

The $99/year fee alone has been the reason most devs stayed away from porting uBlock to Safari.

Apple Developer Program Membership Fee Waivers Now Available just as a note

and thanks el1t for your work !