elBukkit / MagicPlugin

A Bukkit plugin for spells, wands and other magic
http://mine.elmakers.com
MIT License
239 stars 148 forks source link

[Feature Request] Tracking Sense on item_display/block_display entities #1350

Open Remodactyl opened 3 months ago

Remodactyl commented 3 months ago

Most entities in Minecraft can be made to glow using the Glowing Potion Effect (ID: 25), some entities however, like the item_display or block_display don't allow for the glowing effect to be applied, but instead use the Glowing:1b/0b NBT tag.

The feature request is to make use of Glowing:1b/0b where tracking sense currently fails to apply glowing.

For me personally this is useful to adjust Tracking Sense to work on scattered items during quests in my game. Which would then look like this: image

An addition to this Feature Request would be to make a separate entry in the TargetType Enum. 'DISPLAY_ENTITY' which covers item_display, entity_display and block_display entities. This could then be specified in the target_type parameter of a spell.

Remodactyl commented 3 months ago

Additionally, there seems to be a bug that when an item_display entity is sensed through Tracking Sense, it does not use the CustomName in the display message, it simply states 'You sense display item nearby'