search

elBukkit / PreciousStones

Self-service protection for Minecraft servers
http://dev.bukkit.org/server-mods/preciousstones/
10 stars 10 forks source link

Sadly, Precious Stones, it is not up to MC1.20.x yet. #142

Open MrKiller01 opened 1 year ago

MrKiller01 commented 1 year ago

I really do hope that the current developer is able to update this marvelous plugin to the next level of Minecraft. Thanks you very much.

xGlenor commented 1 year ago

@MrKiller01 Is something not working? I just tested this version and it loaded correctly on 1.20.1 https://github.com/xGlenor/PreciousStones/releases/tag/1.19

MrKiller01 commented 1 year ago

I did not find or was able to find a newer version. At startup with 1.20.1 it errors, so after testing other plugins I decided to make a full backup of all servers without them active, because other plugins needed updating and ruined at first the world, and some data. So, I'm far from ready, so I'll keep testing this and if I stay silent, it works again. Thanks for reaching out.

MrKiller01 commented 1 year ago

@xGlenor Are you the new maintainer of this plugin? If that is so, maybe go to SpigotMC to put it there? (So I can find you in the future.) Would be sad to get lost... Thanks!

FireController1847 commented 1 year ago

Plugin loaded fine on my test server. DynmapPS is still compatible and working. I'll use this issue to report any initial 1.20 bugs we may find on our production server, but so far all seems to be working fine. I'm sure there's probably 1.20 specific things that may need to be checked (like #139), but I figure they'll be tackled as they come. So far, we've used PS on our 1.19.4 server with no issues whatsoever.

MrKiller01 commented 1 year ago

Plugin loaded fine on my test server. DynmapPS is still compatible and working. I'll use this issue to report any initial 1.20 bugs we may find on our production server, but so far all seems to be working fine. I'm sure there's probably 1.20 specific things that may need to be checked (like #139), but I figure they'll be tackled as they come. So far, we've used PS on our 1.19.4 server with no issues whatsoever.

We also came from 1.19.4, that was not an issue, when it came from 1.18 to 1.19 THEN it was an issue, but that is solved.

FireController1847 commented 12 months ago

Okay, the only issue I've noticed so far is with the editable signs. The prevent-use flags correctly prevents them, so it is working. It's likely more of a feature request to add a prevent-use-signs option which would be able to keep the prevent-use set to true, without allowing signs to be edited. So it's mostly a FR with an easy workaround. Other than this, everything else is working fine.

xtomyserrax commented 2 months ago

@xGlenor @FireController1847 Hey guys, if any of you wants to make a PR to make this compatible with 1.20.* ill merge it if you confirm it works with that version.

The same if you want to make bug fixes!

MrKiller01 commented 2 months ago

I think this issue is way too old because the problems have been solved, apparently this post was just to inform the current developer and not to start a widespread discussion. I'm glad there are people who still care about the beauty of programming some people made and that those not disappear. Still using this and now being at 1.20.4 on my servers, IT STILL WORKS!

xGlenor commented 2 months ago

@xtomyserrax Hi, I may try to do this this coming weekend and will get back to you