Replace icacls.exe with WinAPI

elabit / robotmk

Robotmk - the Robot Framework integration for Checkmk

https://robotmk.org

GNU General Public License v2.0

54 stars 9 forks source link

Replace icacls.exe with WinAPI #565

Closed SoloJacobs closed 2 months ago

SoloJacobs commented 2 months ago

CMK-17607

Some more testing revealed, that we don't actually need GetNamedSecurityInfoW. I am not sure why it is shown by Windows documentation (all links in commit). This cuts done the size of the change by half, which is already much better.

Also, it appears that SetNamedSecurityInfoW is used much more frequently than icacls.exe. So maybe we should reconsider adding this.

jherbel commented 2 months ago

It doesn't look that bad anymore, I am leaning towards going ahead an replacing icacls.exe with this. What is your opinion?

SoloJacobs commented 2 months ago

I have gone ahead and implemented the change fully here: https://github.com/elabit/robotmk/pull/568. Let's discuss it there.