elad-bar / ha-edgeos

Integration with EdgeOS (Ubiquiti)
134 stars 23 forks source link

Edgerouter X - not all interfaces are found after 2.1.1 #137

Open benjycov opened 3 months ago

benjycov commented 3 months ago

With 2.1.1 and 2.1.2 I have had to delete my original routers and readd.

I have 2 Edgerouter 12s, and both are discovering all of their interfaces okay. I have 1 Edgerouter X and only the switch and vtun interfaces are being found, no eth interfaces.

benjycov commented 3 months ago

Just to add I'm seeing lots of log errors for openvpn:

2024-05-04 11:51:08.580 ERROR (MainThread) [custom_components.edgeos.data_processors.interface_processor] Failed to extract Interfaces data, Error: 'openvpn' is not a valid InterfaceTypes, Line: 105

Though if I monitor VTUN interfaces their stats seem to be okay.

elad-bar commented 3 months ago

please provide diagnostic file so I will be able to analyze how it is configured, thanks

Gunth commented 3 months ago

Same issue:

Logger: custom_components.edgeos.data_processors.interface_processor
Source: custom_components/edgeos/data_processors/interface_processor.py:115
integration: Ubiquiti EdgeOS Routers (documentation, issues)

First occurred: 10:56:30 (773 occurrences)
Last logged: 11:08:12

Failed to extract Interfaces data, Error: 'wireguard' is not a valid InterfaceTypes, Line: 105

Here is the diagnostic file :

benjycov commented 3 months ago

please provide diagnostic file so I will be able to analyze how it is configured, thanks

diagnostics attached.

A little more information:

1) All three routers I have are logging the 'openvpn' is not a valid interfacetype, however the OpenVPN interfaces are all being monitored correctly. So this error may not be the root cause of this problem. 2) The router that isn't finding all the interfaces has a slightly unusual 'peth' interface, so perhaps that is causing the problem.

Thanks for sorting this, and this addon in general, its very helpful! :)

elad-bar commented 3 months ago

released v2.1.3, can you please check if it is working for you?

CatalinGB commented 3 months ago

Working as expected, thanks for the quick fix!

Gunth commented 3 months ago

Also correctly working now, thanks a lot !

dar3khudy commented 3 months ago

With ER-X it is presenting all interfaces but for ER-12 it is only showing bond and vtun, all eth are missing.

PS: did anyone above opened the json file which attached ? There are passwords for example for dynamic dns accounts without any encryption, also mac addresses and a lot of information which shouldn't be posted in public!!!

elad-bar commented 3 months ago

With ER-X it is presenting all interfaces but for ER-12 it is only showing bond and vtun, all eth are missing.

please send me diagnostic file, you can send it directly to my mail (elad.bar@hotmail.com).

PS: did anyone above opened the json file which attached ? There are passwords for example for dynamic dns accounts without any encryption, also mac addresses and a lot of information which shouldn't be posted in public!!!

removed links from comments, thanks for raising it, will redact that data, if you can point me to a path in which it is available

elad-bar commented 3 months ago

@dar3khudy thanks for the diagnostic file, I think I understand the root cause - interface is being created using websocket before rest api call, Which supposed to work first, As result of that interface is marked as non supported (missing details), Since I do see that details are available, I would like to protect that flow by doing upsert (update or insert) from rest api, as opposed for today which is insert new only... I will try to do it later today

elad-bar commented 3 months ago

pls check v2.1.4

benjycov commented 3 months ago

Okay I've just tried it, and it is now only finding my 2 x VTUN interfaces, none of the others, however I am getting an (hopefully) useful error message:

2024-05-13 14:07:18.541 ERROR (MainThread) [custom_components.edgeos.data_processors.interface_processor] Failed to extract Interfaces data, Error: 'pseudo-ethernet' is not a valid InterfaceTypes, Line: 105

So maybe it's getting to the PETH interface and stalling?

On Mon, 13 May 2024 at 09:45, Elad Bar @.***> wrote:

pls check v2.1.4 https://github.com/elad-bar/ha-edgeos/releases/tag/v2.1.4

— Reply to this email directly, view it on GitHub https://github.com/elad-bar/ha-edgeos/issues/137#issuecomment-2106993282, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQZVQ2DZVTDZPBCYXWU3QJTZCB4SDAVCNFSM6AAAAABHGXOVISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBWHE4TGMRYGI . You are receiving this because you authored the thread.Message ID: @.***>

elad-bar commented 3 months ago

it's not an actual error but warning, it means that the intergation will ignore that interface, need to move it to debug message, it should present the following interfaces: considered as: ethernet, bridge, switch, openvpn, wireguard name starts with: pppoe, vtun, bond

it means that devices that are: loopback or their name starts with: imq, npi, lo - will be ignored by intentionally.

interfaces that are not matching to any of the criteria above, will be ignored and the message is coming to serve when trying to understand the reason why it is not supported...

if you think interfaces are missing, please send me the diagnostic file over an email to elad.bar@hotmail.com

thanks

benjycov commented 3 months ago

Thanks, yes it's finding less interfaces than before, not even the switch interfaces, I'll send you the diagnostics.

On Mon, 13 May 2024 at 14:29, Elad Bar @.***> wrote:

it's not an actual error but warning, it means that the intergation will ignore that interface, need to move it to debug message, it should present the following interfaces: considered as: ethernet, bridge, switch, openvpn, wireguard name starts with: pppoe, vtun, bond

it means that devices that are: loopback or their name starts with: imq, npi, lo - will be ignored by intentionally.

interfaces that are not matching to any of the criteria above, will be ignored and the message is coming to serve when trying to understand the reason why it is not supported...

if you think interfaces are missing, please send me the diagnostic file over an email to @.***

thanks

— Reply to this email directly, view it on GitHub https://github.com/elad-bar/ha-edgeos/issues/137#issuecomment-2107584587, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQZVQ2EE375SVYJPAUJH4B3ZCC55NAVCNFSM6AAAAABHGXOVISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBXGU4DINJYG4 . You are receiving this because you authored the thread.Message ID: @.***>

elad-bar commented 3 months ago

@dar3khudy you are using v2.1.3, it was fixed in v2.1.4

corrected mention :)

elad-bar commented 3 months ago

@benjycov can you please remove it, restart and add it again, something wrong over there generated lots of empty devices, i suspect it has something to do with it

dar3khudy commented 3 months ago

@dar3khudy you are using v2.1.3, it was fixed in v2.1.4

corrected mention :) Did you read the right file because inside there is an info that I'm using 2.1.4

"edgeos": {
  "documentation": "https://github.com/elad-bar/ha-edgeos",
  "version": "2.1.4",
  "requirements": [
    "aiohttp"
  ]
},
benjycov commented 3 months ago

Okay, I tried removing, rebooting and re-adding. Same problem.

I have another site with 3 more Edgerouters which i tried, the two routers with PETH interfaces failed to configure, found the VTUN interfaces then stopped. I removed the PETH interface from one of the routers, re-added it and straight away it worked and completed setup.

So it is definitely the PETH interfaces causing the problem, you can add a PETH interface to any ETH interface, such as:

pseudo-ethernet peth1 {
    address 192.168.100.252/24
    description "Starlink Management"
    link eth1
}

So it should be easy to replicate.

Also I then noticed that it isn't adding sub interfaces of switch interfaces anymore, it only finds switch0 but not switch 0.1, etc.

On Mon, 13 May 2024 at 16:14, Elad Bar @.***> wrote:

@benjycov https://github.com/benjycov can you please remove it, restart and add it again, something wrong over there generated lots of empty devices, i suspect it has something to do with it

— Reply to this email directly, view it on GitHub https://github.com/elad-bar/ha-edgeos/issues/137#issuecomment-2107948459, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQZVQ2D5VNFX6JCAR3RWYXDZCDKHDAVCNFSM6AAAAABHGXOVISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBXHE2DQNBVHE . You are receiving this because you were mentioned.Message ID: @.***>

elad-bar commented 3 months ago

Found it, it seems that it's not working as i described, it fails the process if the type is not available, Will fix it and release new version later today

elad-bar commented 3 months ago

added fix in v2.1.5

dar3khudy commented 3 months ago

v2.1.5 for me is working fine ! thank you.

elad-bar commented 3 months ago

@benjycov pls let me know if now it works for you as well

thanks

benjycov commented 3 months ago

Hi,

Just tried 2.1.6, and still 2 problems:

1) Routers with Peth interfaces only find the VTUN interfaces then no others. I've deleted, rebooted and readded. 2) Routers (ER-X) with a switch interface only show switch0 and none of the sub interfaces.

Sorry!

On Tue, 14 May 2024 at 14:43, Elad Bar @.***> wrote:

@benjycov https://github.com/benjycov pls let me know if now it works for you as well

thanks

— Reply to this email directly, view it on GitHub https://github.com/elad-bar/ha-edgeos/issues/137#issuecomment-2110283133, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQZVQ2F35FXPUVMMIC3KPH3ZCIIJXAVCNFSM6AAAAABHGXOVISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJQGI4DGMJTGM . You are receiving this because you were mentioned.Message ID: @.***>

elad-bar commented 3 months ago

Can you pls send me again over the mail diagnostic file and logs with v2.1.6? Thank you for assisting fixing the issue, sorry it takes time :)

Sub interfaces are not supported, i need to learns it's structure and functionality before exposing it in HA

benjycov commented 3 months ago

I will email it through in a moment.

Re sub interfaces, apologies I thought we had these before, but actually now I realise we didn't.

On Tue, 14 May 2024 at 15:50, Elad Bar @.***> wrote:

Can you pls send me again over the mail diagnostic file and logs with v2.1.6? Thank you for assisting fixing the issue, sorry it takes time :)

Sub interfaces are not supported, i need to learns it's structure and functionality before exposing it in HA

— Reply to this email directly, view it on GitHub https://github.com/elad-bar/ha-edgeos/issues/137#issuecomment-2110448241, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQZVQ2D6WEDBTIGATQNFDYLZCIQDTAVCNFSM6AAAAABHGXOVISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJQGQ2DQMRUGE . You are receiving this because you were mentioned.Message ID: @.***>

TraceWilson commented 1 month ago

ha-edgeos v2.1.8 not detecting vlan interfaces. At least 1 previous version was working, but now none of the vlan interfaces (SWITCH0.10, etc) are being detected.