search

elad-bar / ha-edgeos

Integration with EdgeOS (Ubiquiti)
133 stars 24 forks source link

Config port isn't used to connect to EdgeOS #74

Closed ALERTua closed 2 years ago

ALERTua commented 2 years ago

The Port configuration value isn't used to connect to EdgeOS, the URL only forms out of the hardcoded HTTPS protocol and Host value. Maybe it would be better to rename Host to URL and remove the Port key? Thank you

elad-bar commented 2 years ago

I thought about it as well, but some of the poeple over the time talked with me about issue with connectivity and it was because the were using reverse proxy with different port, so to support these users i have set the default port as 443 without option to change the protocol to non-secured (ws / http) and kept it within the configuration ui

elad-bar commented 2 years ago

just so that it is not in use at whole, removing it for next version, thanks

elad-bar commented 2 years ago

removed, please let me know if it looks better

thanks