search

elad / node-cluster-socket.io

Writeup on how to make node.js cluster and socket.io play nice
421 stars 63 forks source link

Fix for Issue #16 #17

Closed zpappa closed 8 years ago

zpappa commented 8 years ago

Fixes the downstream issue with linux systems passing IPV6 and IPV4 information to the connection obtained from net.createServer.

elad commented 8 years ago

I don't understand this change. You're always checking ip[1]. Is this intentional?

carasel commented 8 years ago

Should be checking ip[i]. I had the same issue on mac and used the same fix before seeing this.

elad commented 8 years ago

@carasel care to submit a fixed PR?

elad commented 8 years ago

Closing in favor of #21