To-Do-list-interactive- list

elad237 / My-to-do-list-revierw

To-do-list In this project, I will build a simple yet functional To-do list. A To-do list is a tool that helps to organize your day. It simply lists the things that you need to do and allows you to mark them as complete. I will build a simple website that allows for doing that, and you I will do it using ES6 and Webpack! Have CSS, HTML & JS Linters

MIT License

2 stars 0 forks source link

hello Abdulfatai Badara when you add you do do on the list click on the check box

On Sat, 19 Nov 2022 at 09:45, Abdulfatai Badara @.***> wrote:

@.**** requested changes on this pull request.

Hi @elad237 https://github.com/elad237,

Good job so far! You still need to work on some issues to go to the next project, but you are almost there! Highlights

✅ Linters are passing Required Changes ♻️

Check the comments under the review. I had to add the required comments here. In future kindly submit a PR that contains all the changes you made. [REQUIRED] Kindly add the dustbin icon to each todo item and ensure it removes the todo when clicked. Your Design [image: image] https://user-images.githubusercontent.com/62938735/202842365-1713a8c0-5a2a-4fe5-8919-04a1e2287582.png

[REQUIRED] Kindly change the click event listener on your checkbox to a change event listener Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

You can also consider:

Kindly follow the best practices for commit messages like starting with uppercase using the imperative like update instead of updated

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.

— Reply to this email directly, view it on GitHub https://github.com/elad237/My-to-do-list-revierw/pull/2#pullrequestreview-1187041926, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2B3HHP4D5WZMVYL3YBOVD3WJCHTJANCNFSM6AAAAAASFGBXI4 . You are receiving this because you were mentioned.Message ID: @.***>

hello Abdulfatai Badara when you add you do do on the list click on the check box … On Sat, 19 Nov 2022 at 09:45, Abdulfatai Badara @.> wrote: @*.*** requested changes on this pull request. Hi @elad237 https://github.com/elad237, Good job so far! You still need to work on some issues to go to the next project, but you are almost there! Highlights ✅ Linters are passing Required Changes ♻️ Check the comments under the review. I had to add the required comments here. In future kindly submit a PR that contains all the changes you made. [REQUIRED] Kindly add the dustbin icon to each todo item and ensure it removes the todo when clicked. Your Design [image: image] https://user-images.githubusercontent.com/62938735/202842365-1713a8c0-5a2a-4fe5-8919-04a1e2287582.png [REQUIRED] Kindly change the click event listener on your checkbox to a change event listener Optional suggestions Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. You can also consider: - Kindly follow the best practices for commit messages like starting with uppercase using the imperative like update instead of updated Cheers and Happy coding!👏👏👏 Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification. Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise. ------------------------------ As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s. — Reply to this email directly, view it on GitHub <#2 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2B3HHP4D5WZMVYL3YBOVD3WJCHTJANCNFSM6AAAAAASFGBXI4 . You are receiving this because you were mentioned.Message ID: @.>

elad237 / My-to-do-list-revierw

To-Do-list-interactive- list #2

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.