search

elad237 / javascript-capstone

MIT License
1 stars 0 forks source link

Comment #3

Closed elad237 closed 1 year ago

elad237 commented 1 year ago

In this milestone:

EngruugbeJimmy commented 1 year ago

Awesome minion

✔️ Status: APPROVED 🏆 🎉 🎊

Hi @ elad237, You did a really great job! 💯 Congratulations! 🎉 🎉 🎉

I reviewed your code and I see you completed your assigned tasks: -Comments popup

When the popup loads, the webapp retrieves data from: ✅The selected API and shows details about the selected item. ✅The Involvement API to show the item comments. ✅When the user clicks on the "Comment" button, the data is recorded in the ✅Involvement API and the screen is updated.

You may now close this Pull Request and merge the changes!

Other highlights: ✅ Descriptive pull request message ✅ Linter error checks validated ✅ Documented work professionally ✅ Commit messages are meaningful.

Optional suggestions Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Cheers and Happy coding! Feel free to leave any questions or comments in the PR thread if something is not 100% clear.