elad2412 / the-new-css-reset

The New Simple and Lighter CSS Reset
https://elad2412.github.io/the-new-css-reset/
MIT License
2.26k stars 229 forks source link

Remove details summary webkit styles #81

Closed dumindu closed 1 year ago

dumindu commented 1 year ago

Safari

Screenshot 2023-11-06 at 5 24 40 PM
fabulousgk commented 1 year ago

IMO this should be seperated out as its own selector, as it has nothing to do with display-hidden other than sharing the same property.

Would be clearer I belive.

Also only the psuedo is needed.

::-webkit-details-marker { display: none; }

fabulousgk commented 1 year ago

Alos stupid Safari, I mean for reals....lol

dumindu commented 1 year ago

Can use directly ::-webkit-details-marker but should I group all similar style resets into 1 block or not?

Ex. Both :where([hidden]) and ::-webkit-details-marker having only display: none

cc @elad2412 @elektronik2k5 @fabulousgk

fabulousgk commented 1 year ago

Either way works, I just personally like it separated as to me it is more clear there are two separate issues being addressed. That is just an opinion though.

I can see the arguments for them being together as well.

fabulousgk commented 1 year ago

Look at dialog and pre as examples of existing items kept separate.

dumindu commented 1 year ago

Make sense. Updated.