search

elad661 / curlbus

Terminal based UI for Israeli public transit data
41 stars 7 forks source link

Add docker support #21

Closed guysoft closed 5 years ago

guysoft commented 5 years ago

Initial support to get curlbus working on a docker container.

Automated image built for now at: https://hub.docker.com/r/guysoft/curlbus/

guysoft commented 5 years ago

Instance running using the docker container and instructions in the README: https://curlbus.gnethomelinux.com/

elad661 commented 5 years ago

I'm sorry for the delay in reviewing, I'm very busy lately. I will try to find time for this soon

guysoft commented 5 years ago

Ok, is there anything that is blocking you from pulling this?

guysoft commented 5 years ago

Added fixes for two comments, the third I do not know how to make more elegant.

guysoft commented 5 years ago

Also, you might want to create a docker hub automated build so image: guysoft/curlbus could be updated

elad661 commented 5 years ago

Merged, thank you for your work and sorry for the delay

guysoft commented 5 years ago

Complex is better than complicated :) Thanks for merging!