I've added Spanish to the cities.json file and updated the version in package{-lock}.json

arnon001 commented 10 months ago

That's all I did right now, Can you push please to npm?

eladnava commented 10 months ago

Hi @arnon001, Thanks for your contribution!

There are 34 cities missing a Spanish translation, can you please check and fix it?

 ביר הדאג'
 בני עי'ש
 בסמ"ה
 גבעון החדשה
 גבעת כ'ח
 גבעת ניל'י
 גדיש
 גני מודיעין
 דוב'ב
 יד רמב'ם
 ייט'ב
 כפר ביל'ו
 כפר הרא'ה
 כפר הרי'ף וצומת ראם
 כפר חב'ד
 כפר מל'ל
 כרם בן שמן
 כרם מהר'ל
 מלאה
 מצפה אבי'ב
 מרכז אומן
 מרכז מיר'ב
 נאות חובב
 נווה אטי'ב
 ניל'י
 ניר ח'ן
 ניר יפה
 נתיב הל'ה
 עין הנצי'ב
 עין חרוד איחוד
 פעמי תש'ז
 פקיעין החדשה
 רמת רחל
 תלמי ביל'ו

arnon001 commented 10 months ago

Sure, I will check it later today

HoshenKadosh commented 10 months ago

@arnon001 spanish Translation credit goes to Noam Hashmonai who translated them for the Tzofar app. as well as the credit for the polygons from the Tzofar app.. People have put work into this, kinda not right to not give a credit.

@eladnava some cities like גני מודיעין has been renamed to חשמונאים, but on pikud haoref website the old name was not deleted for some reason.

eladnava commented 10 months ago

Hi @HoshenKadosh, Thanks for letting me know where the polygon data and translations came from, and thanks for all your hard work on your app and for gathering the polygon data!

Credits are now given in both the redalert-android and pikud-haoref-api repositories. It will also be given on the Google Play listing.

eladnava / pikud-haoref-api

I've added Spanish to the cities.json file and updated the version in package{-lock}.json #30