search

elai950 / AlertToast

Create Apple-like alerts & toasts using SwiftUI
https://elai950.github.io/AlertToast/
MIT License
2.12k stars 191 forks source link

Long Subtitle text doesn't correctly wrap in DisplayMode "hub" or "banner" #61

Open octopussy1 opened 1 year ago

octopussy1 commented 1 year ago

Describe the bug When using a long Subtitle and in DisplayMode "hub" or "banner" the subtitle doesn't wrap correctly and cuts off on both sides left and right

To Reproduce Steps to reproduce the behavior:

The following code will demonstrate the issue

AlertToast(displayMode: .alert,
        type: .regular,
        title: "Sample Message",
        subTitle: "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Donec gravida eleifend scelerisque. Donec ornare malesuada orci, nec tempus massa lacinia non.\n\nMaecenas sit amet convallis orci. Aenean malesuada lacus sed odio pulvinar elementum non a tellus. Etiam cursus erat sed fermentum lobortis. Phasellus feugiat euismod orci. Donec ultrices fringilla fringilla.")

Expected behavior The text should be displayed the same way it does with DisplayMode "alert".

Screenshots

image This is the toast using "hud"

image This is the toast using "alert"

Smartphon:

elai950 commented 1 year ago

Which version of AlertToast did you installed?

octopussy1 commented 1 year ago

1.3.9

On 15. Feb 2023, at 12:31, Elai Zuberman @.***> wrote:

Which version of AlertToast did you installed?

— Reply to this email directly, view it on GitHub https://github.com/elai950/AlertToast/issues/61#issuecomment-1431223762, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB5PAFD4PNI3AIU4XIZRRNDWXS5BNANCNFSM6AAAAAAU4V5MFY. You are receiving this because you authored the thread.

tanmays commented 1 year ago

@elai950 I ran into this and the v1.3.9 release does not contain the commit 638f38f9daf08e17b7caea22d2fcb9c0a418d1b6.

bradmartin commented 1 year ago

Yea still the issue, modifying the file directly with the commit ^ in your project Pods is an option assuming you commit pods to your repo.

lukepistrol commented 1 year ago

Is this still happening in iOS 16.4? We currently have a report referencing this exact issue running iOS 16.3.1 but we cannot reproduce the issue on our devices running 16.4 or the simulator running 16.2 or 16.4.

guyaumetremblay commented 7 months ago

@elai950 Could you have a look why the 1.3.9 doesn't contain the commit please?