search

elaineshijie / pe

0 stars 0 forks source link

Role of persons in an address book #11

Open elaineshijie opened 1 year ago

elaineshijie commented 1 year ago

Screenshot 2023-11-17 at 5.09.17 PM.png

Multiple roles can be assigned to a person, that shouldnt be the case as a TA cannot also be a Professor

nus-pe-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Able to add a person with both student and professor

Describe the bug

  • We are able to add a person with roles student and professor, which is not possible in real life.

To Reproduce

  1. Input add --name Charlie Dueet --role Professor, Student --contact @charliee, charliee@gmail.com --course GEA1000, QF2103

Expected Behaviour They should aware the user that they might make a mistake

Screenshot image.png

[original: nus-cs2103-AY2324S1/pe-interim#5648] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Our product is intended to be this way which is that each Person can take on any 3 roles of Student, TA and Professor. Also, in real life, it is not impossible for a person to be a student, a TA and a professor at the same time. For instance, a PhD student can be a Student, a TA and a Professor at the same time.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** From the user's point of view and my understanding, the role that is indicated would be the relationship the user has with the added person. Hence, even if a PhD student is a student, the user is more likely to set a person as Professor if the added person is the user's Professor instead of adding two roles. If the user is viewing a profile that he/she has added long ago, the user will also get confused as to why someone is indicated as a student and Professor. Hence, there should not be multiple roles for one person and the expected behavior should be an error or warning message.