search

elaird / supy

analyze events stored in TTrees in parallel
8 stars 7 forks source link

Blre suggestions, round 2 #108

Closed betchart closed 12 years ago

betchart commented 12 years ago

Hi Davide,

I realized that we can probably just add regex functionality to the blacklist we already had, rather than adding a completely new argument for blacklistre.

I also realized that you hadn't been calling re.match, but what looks to me like .match, which doesn't exist, and then I realized that maybe you had been passing re pattern objects rather than strings in blacklistRe. I think it is better to pass strings and call re.match(pattern, plotname), as you see in this set of commits, which also allows us to merge blacklist and blacklistRe into a single argument.

gerbaudo commented 12 years ago

Hi Bert,

Yes, in my implementation I was indeed passing in a list of regexp objects: blackListRe = [re.compile(r'num'), ...]

You implementation is better indeed, thanks for writing it!

Now merging blre-suggestions into blacklist-regexp.

betchart commented 12 years ago

It looks like you closed this pull request rather than merge it. Reopening and merging now.

gerbaudo commented 12 years ago

Opps, sorry, I thought I clicked on 'merge and close'. Thanks for fixing this,

davide

On Tue, May 29, 2012 at 3:42 AM, Burt Betchart < reply@reply.github.com

wrote:

It looks like you closed this pull request rather than merge it. Reopening and merging now.

Reply to this email directly or view it on GitHub: https://github.com/elaird/supy/pull/108#issuecomment-5974450