search

elaird / supy

analyze events stored in TTrees in parallel
8 stars 7 forks source link

Avoid unnecessary call to TChain::GetEntries() #112

Closed betchart closed 12 years ago

betchart commented 12 years ago

Hi Ted,

This actually results in -1 line of code, and I hope it will rectify the noted abuse of dCache. There is a major difference running interactively on lx05: looping starts immediately over the ~2400 files in my SingleMu.2011A sample, rather than apparently hanging while opening all the files to get their number of entries.

I don't see any termination logic problems either. I am running a batch queue test now with nEntries=None, and my success criteria is that jobs finish normally with no crash.

I think it's ok to go ahead and pull this into master.

Burt

elaird commented 12 years ago

Thanks; merging now.

betchart commented 12 years ago

BTW: The batch test also completed successfully.

gerbaudo commented 12 years ago

I see a significant speedup and no problems so far. Thanks, Burt!