elaird / supy

analyze events stored in TTrees in parallel
8 stars 7 forks source link

move the tree path from TChain::Add to TChain::TChain #95

Closed gerbaudo closed 12 years ago

gerbaudo commented 12 years ago

Hi,

This should not be an issue reported to supy, but to the people making this kind of files :-( I have some files on castor that don't contain the '.root' extension (the same happens when the files are on local disk, though). When supy calls

chain.Add("%s/%s/%s"%(infile, dirName, treeName))(

root tries to open what is in fact 'file+dir+treename', that looks like: SysError in TRFIOFile::TRFIOFile: file rfio:////castor/cern.ch/grid/atlas/tzero//.NTUP_TRIG.x191_m1109._0001.1///trigger can not be opened for reading (Not a directory)

I could get it to work by moving the tree name (+path) from TChain::Add to the TChain costructor. However, with this solution I had to change the name of the chain (was 'chain0', 'chain1', etc.). For me it works fine...I don't know whether there was any specific reason for this name.

Thanks,

davide

gerbaudo commented 12 years ago

We will close this and include it in multiexperiment

betchart commented 12 years ago

Hi Davide,

Can you make the code read "for treeDir,treeName in BLAH" rather than "for item in BLAH" followed by use of item[0] and item[1]?

Burt

gerbaudo commented 12 years ago

Hi Burt,

Ted made the same comment :-) does it look OK here? https://github.com/elaird/supy/blob/multiexperiment/__analysisLooper__.py#L107

Thanks,

davide