search

elalish / manifold

Geometry library for topological robustness
Apache License 2.0
748 stars 73 forks source link

mesh id handling #702

Open pca006132 opened 6 months ago

pca006132 commented 6 months ago

See #678 for discussion. Basically:

  1. Use zero as a special mesh ID. IncrementMeshIDs will only remap non-zero IDs. Constructors automatically assign mesh ID zero. This allows coplanar triangles to be collapsed by default unless explicitly opt-out.
  2. Allow AsOriginal(id) to take an optional parameter to specify the ID to apply to. This allows preserving the ID zero.
pca006132 commented 5 months ago

@onlynadeem what is this? our project is not a python project, and even if it is a python project you are leaving so much implementation details. Maybe you can have a look at the code and submit a PR for your changes if you are interested in working on it.

elalish commented 5 months ago

Is this GSOC-related?

onlynadeem commented 5 months ago

This is completely related and I am a beginner in this field and I want to learn to contribute in open source.

elalish commented 4 months ago

Sorry @onlynadeem, we're new to GSoC this year too. I'm glad to hear you're interested in our project! Perhaps you can share a bit of what makes this project interesting to you? Any idea how you might like to contribute?