Open wtholliday opened 1 day ago
Yeah, some of that is actually in process now. But we have a fair number of those warnings silenced already as they can get pretty pedantic.
Probably need -DCMAKE_CXX_FLAGS="-Wno-shorten-64-to-32"
.
I had a look at this, there are simply too many changes required, and we have to change the internal halfedges to 64-bit which can affect performance and require further evaluation. I think for now the only way is to silence the warning.
@pca006132 what about adding casts in the code? Also that particular warning above can be fixed by changing the int
to a size_t
it seems.
This requires a lot of changes. For each one it is simple, but there are many of them...
I'm trying to compile manifold as an xcframework for iOS.
Doing this:
(I'm using this toolchain file https://github.com/leetal/ios-cmake)
I get various errors like:
Probably can silence those warnings (though I'm lousy with CMake and
-DCMAKE_COMPILE_WARNING_AS_ERROR=OFF
didn't do anything), but might be good to fix the underlying thing.