search

elamperti / OpenWebScrobbler

🎧 An open source web scrobbler for Last.fm
https://openscrobbler.com/
GNU General Public License v2.0
312 stars 36 forks source link

An album page is missing when clicked on the album icon #215

Closed silversonicaxel closed 10 months ago

silversonicaxel commented 11 months ago

Describe the bug An album page is missing when clicked on the album icon after a research that gives valid results. Could be some issues since the band name has the ' character in its name? Although other album of the same band is reachable.

Steps to reproduce

  1. Go to Album Search
  2. Search for Rifkin Kazan' via LastFm
  3. Select Album Disco Solare
  4. Reselect same band through breandcrumb
  5. Select Album Bulgarian Nirvana Marasma
  6. Wrong page displayed

Expected behavior Album Bulgarian Nirvana Marasma page should be displayed.

Screenshots /

Device

Platform (please complete the following information):

Additional context /

elamperti commented 10 months ago

Thanks for your report! I was able to reproduce this issue.

I've been experimenting over the weekend with different encodings (plain, HTML entities, URI escape codes) and comparing the results coming from lastfm. It's not completely clear to me how the ' symbol is affecting results, since they do change, but not as I would have expected.

Searching for other terms such as Don't stop believin', rock 'n' roll or just don't, and comparing them with the same term stripped of tildes show very different results. I think removing this character or replacing it with its encoded counterparts will hurt search results in most cases.

I'm not sure if there's something we can do to improve this (besides using Discogs instead of lastfm). I'll be closing the ticket, as it's something I think I can't fix. Ideas are welcome, so feel free to re-open if you see a way to fix or improve results! :)