Further Improvement eslint WIP - Githubissues

elamperti / OpenWebScrobbler

🎧 An open source web scrobbler for Last.fm

https://openscrobbler.com/

GNU General Public License v2.0

312 stars 36 forks source link

Further Improvement eslint WIP #239

Closed silversonicaxel closed 2 weeks ago

silversonicaxel commented 2 weeks ago

my intent was to fix the eslint command, remove the warnings and ... improve the imports at the beginning of the file to

sort alphabetically, prefering types at the beginning of the file
group per typology
isolate the imports from rest of the code

@elamperti feel free to ask me to drop this commit https://github.com/elamperti/OpenWebScrobbler/pull/239/commits/d58a42f25d889ed3c582111ac9dc6c07a5d6bd46 since it touches so many files.

it was just a personal preference.

Still, it is not yet working as expected. I will keep checking (or maybe drop the second commit and leave just the first)

silversonicaxel commented 2 weeks ago

The first actually can be merged https://github.com/elamperti/OpenWebScrobbler/pull/240

silversonicaxel commented 2 weeks ago

Closed. Not super important.