search

elan-ev / opencast-studio

Web-based recording studio for Opencast
https://studio.opencast.org
MIT License
50 stars 46 forks source link

Take another look at the shortcut overlay #1098

Open JulianKniephoff opened 1 year ago

JulianKniephoff commented 1 year ago

@lkiesow wrote in https://github.com/elan-ev/opencast-studio/pull/1069#issuecomment-1691152010:

Screenshot from 2023-08-24 09-08-32

I like the idea of highlighting shortcuts, even though I'm pressing alt all the time to use accessibility tools. That may be why I realized that there seem to be a number of things missing. It seems odd that e.g. “Shortcuts” has a shortcut, but the buttons right next to that do not.

This also goes for other places in the editor like e.g. the settings (gear) icons.

@LukasKalbertodt responded in https://github.com/elan-ev/opencast-studio/pull/1069#issuecomment-1691246311:

Fair. I'm happy to add more shortcuts in the future. I'm not sure all places you mention really deserve their own shortcut, but that's a discussion we can have after this PR is merged.

@lkiesow added in https://github.com/elan-ev/opencast-studio/pull/1069#issuecomment-1693065913:

The problem is mostly that you introduced the shortcut overlay, which I think looks very odd in its current form. At least on the main menu.

I'm not sure whether this issue is supposed to be mainly about the missing/additional shortcuts, or whether @lkiesow's last comment in particular wants to express some more concerns. Can you elaborate?

lkiesow commented 1 year ago

To give you a specific example, whenever you press <alt> (I do that all the time to access some accessibility options) you now get an overlay showing you potential shortcuts. That's new. Before you just had some shortcuts for functionality that people deemed important. This leads to the user interface looking like this (if you look, for example, to the main menu):

Screenshot from 2023-09-14 12-21-54

So, I get an overlay over one of four icons in the main menu. That looks pretty weird.

What's the solution to this? You could remove the overlay again. Or you could add shortcuts to all menu items. It's just that in it's current form, it's not great.