search

elan-ev / opencast-studio

Web-based recording studio for Opencast
https://studio.opencast.org
MIT License
50 stars 47 forks source link

Add high contrast schemes #1110

Closed LukasKalbertodt closed 1 year ago

LukasKalbertodt commented 1 year ago

Draft as there is still more work to be done. @narickmann will probably take it from here.

narickmann commented 1 year ago

The high contrast mode (hc mode) should now be finished.

Here are some more thoughts I have:

1) The boxShadow was removed everywhere for hc mode. A value for this was set for darkmode and lightmode (--shadow-color), but not in hc mode and it is actually ignored. I still set it to none for hc mode because I'm not sure whether that could otherwise cause problems at some point and in some places the --shadow-color is not used, but a hardcoded value which would be used in hc mode. I think we shouldn't use boxShadow in hc mode because it might be confusing and might not have enough contrast. But I couldn't find anything explicit about it in the WCAG.

2) Let me know what you think about the play-/pause button in the "Review and trim" step when you hover over it.

3) I'm not sure what we should do with the "video-settings" button. I think we should we leave it as it is? (I didn't changed it). If anyone has other thoughts or suggestions, leave a comment.

4) If the hc mode comes into Studio like this, we should adjust the hc mode (for some elements) in the editor. The goal with the new design was to make the applications look related/similar (correct me if I'm wrong). At first glance, this would affect the colors of the drop-down menus (in Studio they have a black/white bg when hovering and in the editor the accent color) and some buttons.

And also let me know if I missed something.

github-actions[bot] commented 1 year ago

This pull request has conflicts ☹ Please resolve those so we can review the pull request. Thanks.

LukasKalbertodt commented 1 year ago

Since Nadine will be absent for the coming two weeks, I quickly fixed most of my comments (and rebased). Some of the less opinionated comments I didn't change. It's still fine like this.

Since I only added very little extra stuff and already reviewed otherwise, I will merge.