elan-ev / studip-opencast-plugin

This is an Stud.IP plugin for Opencast
https://elan-ev.github.io/studip-opencast-plugin/
GNU General Public License v2.0
9 stars 20 forks source link

"Videos/Wiedergabelisten übertragen" is not working #879

Closed kai-wng-uos closed 8 months ago

kai-wng-uos commented 10 months ago

Several issues with this feature:

kai-wng-uos commented 10 months ago

additionally to this, the playlists are laso not copied to the destination course, but linked, meaning that every change to the playlist in one course will effect this playlist in all courses it has been transferred to. This relates to #797. On the other hand, deleting a playlist from a course (no matter if it's the start or destination course) doesn't affect the playlists in transferred courses --> inconsistent.

kai-wng-uos commented 10 months ago

Also, there are always two videos being added to the course playlist of the destination course. These videos were not part of any playlists in the original course, yet they crop up in the course playlist.

kai-wng-uos commented 9 months ago

Further testing shows that the migration between courses seems to be working with all playlists except the course playlist. Here, the migration is very inconsistent. Sometimes it works fine, sometimes only certain videos are transferred, sometimes none. @tgloeggl could this be a test system issue?

dennis531 commented 9 months ago

I think most of the problems could be solved by https://github.com/elan-ev/studip-opencast-plugin/pull/893. Now the "Videos/Wiedergabelisten übertragen" action copies all playlists including the "Kurswiedergabeliste" playlist to the destination course.

dennis531 commented 9 months ago

when you then try to transfer all contents (as the dialog claims) to a different course, all playlists and the videos in those playlists are transferred to the chosen course. However, the videos from the "Kurswiedergabeliste" are not transferred.

Should be solved by #893.

Instead of the videos from the start course's "Kurswiedergabeliste" being transferred to the destination course's "Kurswiedergabeliste", videos from the other transferred playlists are listed there.

Probably caused by https://github.com/elan-ev/studip-opencast-plugin/issues/901. Shoud be solved by https://github.com/elan-ev/studip-opencast-plugin/pull/906.

I have not yet figured out why certain videos from the playlists are shown in the "Kurswiedergabeliste" but other are not

This problem could be related to #901 or is/was caused by false or confusing video permissions.

additionally to this, the playlists are laso not copied to the destination course, but linked, meaning that every change to the playlist in one course will effect this playlist in all courses it has been transferred to. This relates to https://github.com/elan-ev/studip-opencast-plugin/issues/797. On the other hand, deleting a playlist from a course (no matter if it's the start or destination course) doesn't affect the playlists in transferred courses --> inconsistent.

I hope it is solved by #893

dennis531 commented 9 months ago

After https://github.com/elan-ev/studip-opencast-plugin/pull/906 is merged, this function should be tested again.

kai-wng-uos commented 9 months ago

currently not working at all...

https://github.com/elan-ev/studip-opencast-plugin/assets/152959695/7fabc66d-863a-4e9c-bfa5-3ad5413105e2

kai-wng-uos commented 9 months ago

turns out it is working, but the transferred data only appears after you've (manually) created a playlist. Very confusing. Either add a warning that says something like "um Inhalte in diesen Kurs zu übertragen, müssen Sie zunächst eine Standardplaylist in dem Kurs anlegen", or just make the origin course's default playlist the default playlist for the destination course.

dennis531 commented 9 months ago

Possible solution:

Should match the second solution in https://github.com/elan-ev/studip-opencast-plugin/issues/879#issuecomment-1918817854.

kai-wng-uos commented 8 months ago

The initial Problem is solved, however, it still has a few problems:

dennis531 commented 8 months ago
  • To perform the transfer, the OC Plugin has to already be activated. The more elegant solution would be that the transfer automatically activates the plugin in the target course

I am rather against automatically activating the plugin. I think the user should have control over the activation of the plugin in the course. By activating the plugin manually, lecturers can keep better track of which courses are activated, instead of enabling it magically in the background. In addition, we would need to provide some kind of notification when the plugin is activated in the background.

the playlists are displayed in a different order than in the source course

I will fix this problem.

dennis531 commented 8 months ago

Playlists in the course are currently sorted in ascending order by their creation date. The problem occurs because the copied playlists do not copy the creation date, but set the copy date as creation date instead. I tried to copy the playlists sorted by creation date. This approach does not work, as all copied playlists ended with the same creation dates, at least in my test system. So this problem is not trivial to solve as long as we do not offer a sorting option for the playlists in the course. It would be possible to offset the creation dates, e.g. by one second. But that would lead to messy hacks in the code.

In conclusion, it would be best to solve this problem with the planned sorting function of playlists in courses to avoid ugly code.

kai-wng-uos commented 8 months ago
  • To perform the transfer, the OC Plugin has to already be activated. The more elegant solution would be that the transfer automatically activates the plugin in the target course

I am rather against automatically activating the plugin. I think the user should have control over the activation of the plugin in the course. By activating the plugin manually, lecturers can keep better track of which courses are activated, instead of enabling it magically in the background. In addition, we would need to provide some kind of notification when the plugin is activated in the background.

I understand the approach to make actions as transparent as possible. However, I also think in attempting to copy Opencast contents from one course to the next it is clear that a lecturer wants to also activate the plugin, so why make them leave the copying dialog, go to the target course manually, activate the pluging, then return to the original course and start the copying action. To me, this seems unnecessarily tedious. Maybe a notification as to the automatic activation would be a good middle ground?

dennis531 commented 8 months ago

I created new issues for the mentioned problems.