elan-ev / tobira

Video portal for Opencast
https://elan-ev.github.io/tobira/
Apache License 2.0
22 stars 17 forks source link

Adjust sizing and color of new paella icons #1165

Closed owi92 closed 4 months ago

owi92 commented 4 months ago

This makes the new play and spinner icons slightly smaller and thinner, and uses a darker grey.

Bildschirmfoto 2024-05-13 um 12 51 08
oas777 commented 4 months ago

Just a reminder we wanted to test the new design with different videos: "I would suggest you take a look at a couple of videos with different backgrounds. I still think the lighter version works better for a variety of backgrounds, but if as you said the majority of videos will have a white background anyway, the darker version should be ok to use." (Ole)

owi92 commented 4 months ago

Ok so with sizing and stroke-width aka thickness out of the way, this comes down to dark vs light icons. While I said that dark icons should be ok to use, comparing both side by side with dark and light backgrounds, I do still think the light version works better.

Also keep in mind that light preview images tend to have dark/black text which doesn't work great in combination with a dark icon. Though I realize the same could be said vice versa for the light icon. Unfortunately it's hard to find a one-size-fits-all solution, but I'd still advocate for the lighter icon, which also works works better with the spinner icon (that is always on a dark background).

As Lukas said, there will always be some preview image that won't look too good with either version. See the following for a comparison:

Bildschirmfoto 2024-05-20 um 23 41 04

As a footnote: These icons also need an outline so they'll be visible on backgrounds with the exact same color, and here a light icon with dark outline works better than a dark icon with a light outline. The latter tends to look like it's glowing on dark backgrounds. This effect can be seen in the dark icon/dark background combination of the above table.

LukasKalbertodt commented 4 months ago

Thanks Ole for the comparison. My position remains the same as yours: I prefer the white icon.

oas777 commented 4 months ago

Yes, white is the colour to work with.