search

elan-ev / tobira

Video portal for Opencast
https://elan-ev.github.io/tobira/
Apache License 2.0
24 stars 18 forks source link

Allow for the title text to be removed #1269

Open oas777 opened 2 weeks ago

oas777 commented 2 weeks ago

In case you have the name/title of your video site in the logo and want to have a video on top.

image

dagraf commented 4 days ago

+1

Same here in Bern.

Bildschirmfoto 2024-11-12 um 16 38 43
LukasKalbertodt commented 4 days ago

To reduce bloating the configuration too much, I would probably remove this text in 3.0 completely. We only need to provide a way for people to "get that title back" if they want. I see two options:

  1. We make it possible to give a name to the root realm (like any other realm).
  2. We solve it via "Title" blocks.

I think I slightly prefer 1, without having thought about it too much. For all other realms, the name is already rendered as a <h1> element, which is exactly what we want. It would also make the root realm less special, and fewer special cases are always good (note though that the root realm is still special as a null name is allowed, unlike for other realms). Title blocks are currently rendered as <h2> elements, but having those without a <h1> is not great, so we would need to special case "the first title block on the root realm"... which adds special treatment.